tools/gn/parser.cc - Issue 2556613002: gn: Fix stale references in Parser::AssignComments().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/parser.cc

Issue 2556613002: gn: Fix stale references in Parser::AssignComments(). (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/parser.cc

diff --git a/tools/gn/parser.cc b/tools/gn/parser.cc

index 18e1ea12a50960013b0dc14b6b26c69783115a2f..447dfcf5b0fce5466a0aad329594530fe2a25ee9 100644

--- a/tools/gn/parser.cc

+++ b/tools/gn/parser.cc

@@ -851,8 +851,8 @@ void Parser::AssignComments(ParseNode* file) {

if ((*i)->AsFunctionCall() || (*i)->AsList() || (*i)->AsBlock())

continue;

- const Location& start = (*i)->GetRange().begin();

- const Location& end = (*i)->GetRange().end();

+ Location start = (*i)->GetRange().begin();

+ Location end = (*i)->GetRange().end();

// Don't assign suffix comments to something that starts on an earlier

// line, so that in:

« no previous file with comments | « no previous file | no next file » | no next file with comments »