Add a NoStatePrefetch entry in about://flags

Add a NoStatePrefetch entry in about://flags

BUG=668997
Committed: https://crrev.com/85d1ac19c8c12fc04a461eefa0829b613b89d713
Cr-Commit-Position: refs/heads/master@{#437515}

[droger, 2016-12-06 11:58:04]

droger@chromium.org changed reviewers:
+ mattcary@chromium.org, pasko@chromium.org

[droger, 2016-12-06 11:58:05]

This CL depends on the field trial CL  and addresses a suggestion from pasko@
(https://codereview.chromium.org/2537503002/#msg3).

[droger, 2016-12-06 12:01:55]

https://codereview.chromium.org/2556543004/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2556543004/diff/1/chrome/browser/about_flags....
chrome/browser/about_flags.cc:2144: // histograms.xml and don't forget to run
AboutFlagsHistogramTest unit test.
Note: I am not sure if I have to do this or not, since I'm adding a feature and
not a switch.

Looking at other features, it seems inconsistent: some don't do it, other do it,
but use inconsistent values, i.e.:
* my-feature (which is the flag storage key for the feature)
* or my-feature:enabled
* or MyFeature (which is the feature name)

[mattcary, 2016-12-06 12:39:55]

lgtm

It seems to me that since David has figured out how to add this, and it's not
that much work, we may as well do it.

I'm not sure about the LoginCustomFlags histogram. The main reason to not do it
is since these features are somewhat ephemeral, we may not want to pollute the
enum. I have no strong feelings, though.

[droger, 2016-12-07 14:05:15]

pasko: please review as OWNER. This is not urgent, take your time.

[droger, 2016-12-07 14:06:37]

The CQ bit was checked by droger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 14:06:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[droger, 2016-12-07 14:07:24]

droger@chromium.org changed reviewers:
+ asvitkine@chromium.org

[droger, 2016-12-07 14:08:10]

https://codereview.chromium.org/2556543004/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2556543004/diff/1/chrome/browser/about_flags....
chrome/browser/about_flags.cc:2144: // histograms.xml and don't forget to run
AboutFlagsHistogramTest unit test.
On 2016/12/06 12:01:55, droger wrote:
> Note: I am not sure if I have to do this or not, since I'm adding a feature
and
> not a switch.
> 
> Looking at other features, it seems inconsistent: some don't do it, other do
it,
> but use inconsistent values, i.e.:
> * my-feature (which is the flag storage key for the feature)
> * or my-feature:enabled
> * or MyFeature (which is the feature name)

+asvitkine: do you know what I should do here?

[commit-bot: I haz the power, 2016-12-07 14:35:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 14:35:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[droger, 2016-12-07 14:50:26]

The CQ bit was checked by droger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 14:50:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[droger, 2016-12-07 14:51:22]

https://codereview.chromium.org/2556543004/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2556543004/diff/1/chrome/browser/about_flags....
chrome/browser/about_flags.cc:2144: // histograms.xml and don't forget to run
AboutFlagsHistogramTest unit test.
On 2016/12/07 14:08:09, droger wrote:
> On 2016/12/06 12:01:55, droger wrote:
> > Note: I am not sure if I have to do this or not, since I'm adding a feature
> and
> > not a switch.
> > 
> > Looking at other features, it seems inconsistent: some don't do it, other do
> it,
> > but use inconsistent values, i.e.:
> > * my-feature (which is the flag storage key for the feature)
> > * or my-feature:enabled
> > * or MyFeature (which is the feature name)
> 
> +asvitkine: do you know what I should do here?

I think I figured it out and updated histograms.xml, could you review the
changes there?

[commit-bot: I haz the power, 2016-12-07 15:43:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 15:43:07]

Dry run: This issue passed the CQ dry run.

[Alexei Svitkine (slow), 2016-12-07 15:50:00]

lgtm % comment

please associate the CL with a crbug via BUG=

https://codereview.chromium.org/2556543004/diff/40001/chrome/browser/prerende...
File chrome/browser/prerender/prerender_field_trial.h (right):

https://codereview.chromium.org/2556543004/diff/40001/chrome/browser/prerende...
chrome/browser/prerender/prerender_field_trial.h:16: extern const char
kNoStatePrefetchFeatureModeParameterPrefetch[];
Is there a corresponding .cc file change missing from the CL?

[droger, 2016-12-07 15:55:09]

Description was changed from

==========
Add a NoStatePrefetch entry in about://flags
==========

to

==========
Add a NoStatePrefetch entry in about://flags

BUG=668997
==========

[droger, 2016-12-07 15:55:31]

Thanks!

https://codereview.chromium.org/2556543004/diff/40001/chrome/browser/prerende...
File chrome/browser/prerender/prerender_field_trial.h (right):

https://codereview.chromium.org/2556543004/diff/40001/chrome/browser/prerende...
chrome/browser/prerender/prerender_field_trial.h:16: extern const char
kNoStatePrefetchFeatureModeParameterPrefetch[];
On 2016/12/07 15:50:00, Alexei Svitkine wrote:
> Is there a corresponding .cc file change missing from the CL?

No, these constants already exist, they just were made public in this CL.

Note that they were not in anonymous namespace (as they should have been),
that's why there is no change needed to the cc file.

[pasko, 2016-12-08 15:08:58]

lgtm

[droger, 2016-12-09 09:53:20]

The CQ bit was checked by droger@chromium.org

[droger, 2016-12-09 09:53:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
mattcary@chromium.org
Link to the patchset: https://codereview.chromium.org/2556543004/#ps40001
(title: "fix histograms.xml")

[commit-bot: I haz the power, 2016-12-09 09:53:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 11:02:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481277200861270,
"parent_rev": "1197610542c8e8426c86737e381f160c1d925c1f", "commit_rev":
"9af9efb0bd29f232c1f9ad2152a4c5bd37b2274c"}

[commit-bot: I haz the power, 2016-12-09 11:02:49]

Description was changed from

==========
Add a NoStatePrefetch entry in about://flags

BUG=668997
==========

to

==========
Add a NoStatePrefetch entry in about://flags

BUG=668997

Review-Url: https://codereview.chromium.org/2556543004
==========

[commit-bot: I haz the power, 2016-12-09 11:02:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-09 11:04:46]

Description was changed from

==========
Add a NoStatePrefetch entry in about://flags

BUG=668997

Review-Url: https://codereview.chromium.org/2556543004
==========

to

==========
Add a NoStatePrefetch entry in about://flags

BUG=668997

Committed: https://crrev.com/85d1ac19c8c12fc04a461eefa0829b613b89d713
Cr-Commit-Position: refs/heads/master@{#437515}
==========

[commit-bot: I haz the power, 2016-12-09 11:04:47]

Patchset 3 (id:??) landed as
https://crrev.com/85d1ac19c8c12fc04a461eefa0829b613b89d713
Cr-Commit-Position: refs/heads/master@{#437515}