Use mojo typemaps to simplify arc::IntentFilter::IntentFilter() (reland)

Use mojo typemaps to simplify arc::IntentFilter::IntentFilter() (reland)

This patch is the reland of https://crrev.com/6d90e3c056 on the latest tot. The previous patch was reverted due to conflict and build failure.

BUG=665719
R=yusukes@chromium.org, lhchavez@chromium.org
TBR=dcheng@chromium.org
# TBRing since no changes in IPC-related code from the previous patch

Committed: https://crrev.com/a931c678447eacaacac9ebf26373b8b853b236a6
Cr-Commit-Position: refs/heads/master@{#438450}

[yoshiki, 2016-12-06 11:21:31]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 11:21:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 12:21:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 12:21:46]

Dry run: This issue passed the CQ dry run.

[yoshiki, 2016-12-06 17:28:59]

Description was changed from

==========
.

BUG=
==========

to

==========
Use mojo typemaps to simplify arc::IntentFilter::IntentFilter() (reland)

This patch is the reland of https://crrev.com/6d90e3c056 on the latest tot. The
previous patch was reverted due to conflict and build failure.

BUG=665719
TBR=yusukes@chromium.org, lhchavez@chromium.org, dcheng@chromium.org
==========

[yoshiki, 2016-12-06 17:28:59]

yoshiki@chromium.org changed reviewers:
+ dcheng@chromium.org, lhchavez@chromium.org, yusukes@chromium.org

[Luis Héctor Chávez, 2016-12-06 21:25:50]

What did you change? Going forward, please upload the reland as-is first and
then upload a second patch set with the changes needed to make the bots green.

For this particular one, can you do `OLD_HEAD=`git rev-parse HEAD` && git reset
--hard HEAD^ && git revert ${hash} && git cl upload && git reset --hard
${OLD_HEAD} && git cl upload`?

[Yusuke Sato, 2016-12-06 22:08:05]

On 2016/12/06 21:25:50, Luis Héctor Chávez wrote:
> What did you change? Going forward, please upload the reland as-is first and
> then upload a second patch set with the changes needed to make the bots green.
> 
> For this particular one, can you do `OLD_HEAD=`git rev-parse HEAD` && git
reset
> --hard HEAD^ && git revert ${hash} && git cl upload && git reset --hard
> ${OLD_HEAD} && git cl upload`?

+1
Since the build failure was about the initialization with (just) {}, I guess he
fixed only that part, but uploading the original would be much easier to review.

Also, do you know why CQ didn't catch the build failure in the first place? How
can we make sure that this one won't have any issue with the builder?

[Luis Héctor Chávez, 2016-12-06 22:26:18]

On 2016/12/06 22:08:05, Yusuke Sato wrote:
> On 2016/12/06 21:25:50, Luis Héctor Chávez wrote:
> > What did you change? Going forward, please upload the reland as-is first and
> > then upload a second patch set with the changes needed to make the bots
green.
> > 
> > For this particular one, can you do `OLD_HEAD=`git rev-parse HEAD` && git
> reset
> > --hard HEAD^ && git revert ${hash} && git cl upload && git reset --hard
> > ${OLD_HEAD} && git cl upload`?
> 
> +1
> Since the build failure was about the initialization with (just) {}, I guess
he
> fixed only that part, but uploading the original would be much easier to
review.
> 
> Also, do you know why CQ didn't catch the build failure in the first place?
How
> can we make sure that this one won't have any issue with the builder?

The CQ did not catch the failure since the bot that failed is not part of CQ :(

In order to ensure that this won't have any issue with the builder, please

cat > out/Debug/args.gn <<<EOF
ffmpeg_branding = "ChromeOS"
is_component_build = true
is_debug = true
proprietary_codecs = true
target_os = "chromeos"
use_goma = true
EOF

and then

ninja -C out/Debug accessibility_unittests accessibility_unittests_run
app_list_presenter_unittests app_list_presenter_unittests_run app_list_unittests
app_list_unittests_run app_shell_unittests app_shell_unittests_run
ash_content_unittests ash_content_unittests_run ash_unittests ash_unittests_run
aura_builder aura_unittests aura_unittests_run base_unittests base_unittests_run
browser_tests browser_tests_run cacheinvalidation_unittests
cacheinvalidation_unittests_run capture_unittests capture_unittests_run
chrome_app_unittests chrome_app_unittests_run chromeos_unittests
chromeos_unittests_run components_unittests components_unittests_run
compositor_unittests compositor_unittests_run content_browsertests
content_browsertests_run content_unittests content_unittests_run
crypto_unittests crypto_unittests_run device_unittests device_unittests_run
display_unittests display_unittests_run events_unittests events_unittests_run
extensions_browsertests extensions_browsertests_run extensions_unittests
extensions_unittests_run gcm_unit_tests gcm_unit_tests_run gfx_unittests
gfx_unittests_run google_apis_unittests google_apis_unittests_run
gpu_ipc_service_unittests gpu_ipc_service_unittests_run gpu_unittests
gpu_unittests_run interactive_ui_tests interactive_ui_tests_run ipc_tests
ipc_tests_run jingle_unittests jingle_unittests_run media_blink_unittests
media_blink_unittests_run media_unittests media_unittests_run
message_center_unittests message_center_unittests_run midi_unittests
midi_unittests_run nacl_helper_nonsfi_unittests nacl_helper_nonsfi_unittests_run
nacl_loader_unittests nacl_loader_unittests_run net_unittests net_unittests_run
pdf_unittests pdf_unittests_run ppapi_unittests ppapi_unittests_run
remoting_unittests remoting_unittests_run sandbox_linux_unittests
sandbox_linux_unittests_run skia_unittests skia_unittests_run sql_unittests
sql_unittests_run storage_unittests storage_unittests_run ui_arc_unittests
ui_arc_unittests_run ui_base_unittests ui_base_unittests_run
ui_chromeos_unittests ui_chromeos_unittests_run ui_touch_selection_unittests
ui_touch_selection_unittests_run unit_tests unit_tests_run url_unittests
url_unittests_run views_mus_interactive_ui_tests
views_mus_interactive_ui_tests_run views_mus_unittests views_mus_unittests_run
views_unittests views_unittests_run wm_unittests wm_unittests_run -j50

(which is roughly what the bot did on
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...).

[yoshiki, 2016-12-07 02:10:19]

Sorry, this CL was not ready for review. This patch is completely same as the
previous patch and should fail again on the bots. I thought the failure was due
to conflict, but I read the failed log and I realized that the assumption was
not true.

And thank you for giving a good piece of advice. Let me fix the cause of build
failure first and ask you review again after that.

[yoshiki, 2016-12-07 02:12:44]

Description was changed from

==========
Use mojo typemaps to simplify arc::IntentFilter::IntentFilter() (reland)

This patch is the reland of https://crrev.com/6d90e3c056 on the latest tot. The
previous patch was reverted due to conflict and build failure.

BUG=665719
TBR=yusukes@chromium.org, lhchavez@chromium.org, dcheng@chromium.org
==========

to

==========
Use mojo typemaps to simplify arc::IntentFilter::IntentFilter() (reland)

This patch is the reland of https://crrev.com/6d90e3c056 on the latest tot. The
previous patch was reverted due to conflict and build failure.

BUG=665719
R=yusukes@chromium.org, lhchavez@chromium.org, dcheng@chromium.org
==========

[yoshiki, 2016-12-08 20:08:59]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 20:09:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoshiki, 2016-12-08 20:10:58]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[yoshiki, 2016-12-08 20:11:43]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-12-08 20:12:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoshiki, 2016-12-08 20:12:02]

Patchset #2 (id:40001) has been deleted

[yoshiki, 2016-12-08 20:12:26]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 20:12:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoshiki, 2016-12-08 20:13:02]

Patchset #2 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-12-08 20:16:19]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2016-12-08 22:08:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 22:08:22]

Dry run: This issue passed the CQ dry run.

[yoshiki, 2016-12-09 04:14:08]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 04:14:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoshiki, 2016-12-09 04:14:59]

Patchset #2 (id:80001) has been deleted

[yoshiki, 2016-12-09 04:16:20]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 04:16:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 06:05:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 06:05:38]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2016-12-13 22:12:56]

ping? What's the status of the CL?

[yoshiki, 2016-12-14 01:47:15]

Description was changed from

==========
Use mojo typemaps to simplify arc::IntentFilter::IntentFilter() (reland)

This patch is the reland of https://crrev.com/6d90e3c056 on the latest tot. The
previous patch was reverted due to conflict and build failure.

BUG=665719
R=yusukes@chromium.org, lhchavez@chromium.org, dcheng@chromium.org
==========

to

==========
Use mojo typemaps to simplify arc::IntentFilter::IntentFilter() (reland)

This patch is the reland of https://crrev.com/6d90e3c056 on the latest tot. The
previous patch was reverted due to conflict and build failure.

BUG=665719
R=yusukes@chromium.org, lhchavez@chromium.org 
TBR=dcheng@chromium.org
# TBRing since no changes in IPC-related code from the previous patch
==========

[yoshiki, 2016-12-14 01:50:27]

Yusuke-san, Luis, PTAL.

The only difference from the previously-committed patch is in
local_activity_resolver_unittest.cc. And I confirmed this CL fixes the build
failure which had happened in the previous patch.

[Yusuke Sato, 2016-12-14 03:39:40]

lgtm, please make sure that the try failure is not yours.

[yoshiki, 2016-12-14 04:14:15]

The CQ bit was checked by yoshiki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 04:14:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 05:31:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 05:31:50]

Dry run: This issue passed the CQ dry run.

[yoshiki, 2016-12-14 06:55:59]

On 2016/12/14 03:39:40, Yusuke Sato (ooo Dec 16 to 31) wrote:
> lgtm, please make sure that the try failure is not yours.

Thank you for reviewing.

"linux_chromium_gn_chromeos_dbg" bot has been failing recently:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium....
I assume it's no longer maintained. Let me submit.

[yoshiki, 2016-12-14 06:56:06]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2016-12-14 06:56:06]

The patchset sent to the CQ was uploaded after l-g-t-m from yusukes@chromium.org
Link to the patchset: https://codereview.chromium.org/2556463003/#ps120001
(title: "Rebased")

[commit-bot: I haz the power, 2016-12-14 06:56:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 07:23:58]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1481698566312250,
"parent_rev": "566169ab82ca330f7b72ec8159f2b1715be24810", "commit_rev":
"7d097d38ad1d4ac6d6e4e86e2bde20a0a7848c88"}

[commit-bot: I haz the power, 2016-12-14 07:24:23]

Description was changed from

==========
Use mojo typemaps to simplify arc::IntentFilter::IntentFilter() (reland)

This patch is the reland of https://crrev.com/6d90e3c056 on the latest tot. The
previous patch was reverted due to conflict and build failure.

BUG=665719
R=yusukes@chromium.org, lhchavez@chromium.org 
TBR=dcheng@chromium.org
# TBRing since no changes in IPC-related code from the previous patch
==========

to

==========
Use mojo typemaps to simplify arc::IntentFilter::IntentFilter() (reland)

This patch is the reland of https://crrev.com/6d90e3c056 on the latest tot. The
previous patch was reverted due to conflict and build failure.

BUG=665719
R=yusukes@chromium.org, lhchavez@chromium.org 
TBR=dcheng@chromium.org
# TBRing since no changes in IPC-related code from the previous patch

Review-Url: https://codereview.chromium.org/2556463003
==========

[commit-bot: I haz the power, 2016-12-14 07:24:24]

Committed patchset #3 (id:120001)

[commit-bot: I haz the power, 2016-12-14 07:26:25]

Description was changed from

==========
Use mojo typemaps to simplify arc::IntentFilter::IntentFilter() (reland)

This patch is the reland of https://crrev.com/6d90e3c056 on the latest tot. The
previous patch was reverted due to conflict and build failure.

BUG=665719
R=yusukes@chromium.org, lhchavez@chromium.org 
TBR=dcheng@chromium.org
# TBRing since no changes in IPC-related code from the previous patch

Review-Url: https://codereview.chromium.org/2556463003
==========

to

==========
Use mojo typemaps to simplify arc::IntentFilter::IntentFilter() (reland)

This patch is the reland of https://crrev.com/6d90e3c056 on the latest tot. The
previous patch was reverted due to conflict and build failure.

BUG=665719
R=yusukes@chromium.org, lhchavez@chromium.org
TBR=dcheng@chromium.org
# TBRing since no changes in IPC-related code from the previous patch

Committed: https://crrev.com/a931c678447eacaacac9ebf26373b8b853b236a6
Cr-Commit-Position: refs/heads/master@{#438450}
==========

[commit-bot: I haz the power, 2016-12-14 07:26:27]

Patchset 3 (id:??) landed as
https://crrev.com/a931c678447eacaacac9ebf26373b8b853b236a6
Cr-Commit-Position: refs/heads/master@{#438450}