skia/trunk changes for generic sanitizer gyp flag.

skia/trunk changes for generic sanitizer gyp flag.

BUG=
R=borenet@google.com

Committed: https://code.google.com/p/skia/source/detail?r=11648

[mtklein, 2013-10-01 17:33:56]

buildbot side coming soon

[borenet, 2013-10-01 17:49:38]

LGTM with a couple of suggestions.

https://codereview.chromium.org/25564003/diff/6001/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/25564003/diff/6001/gyp/common_conditions.gypi...
gyp/common_conditions.gypi:281: [ 'skia_sanitizer != ""', {
This line can also just be:

[ 'skia_sanitizer', {

https://codereview.chromium.org/25564003/diff/6001/gyp/common_variables.gypi
File gyp/common_variables.gypi (right):

https://codereview.chromium.org/25564003/diff/6001/gyp/common_variables.gypi#...
gyp/common_variables.gypi:121: [ 'skia_sanitizer != ""', {
Again, can just use 'skia_sanitizer'

https://codereview.chromium.org/25564003/diff/6001/gyp/common_variables.gypi#...
gyp/common_variables.gypi:122: 'skia_clang_build': 1,   # What's the difference
between skia_clang_build and skia_clang_build%?
The % at the end of the variable means that we're conditionally assigning it. 
For this if/else in particular, we want to *override* skia_clang_build if we're
doing a *san build, so we avoid using the '%'.

[mtklein, 2013-10-01 17:53:29]

https://codereview.chromium.org/25564003/diff/6001/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/25564003/diff/6001/gyp/common_conditions.gypi...
gyp/common_conditions.gypi:281: [ 'skia_sanitizer != ""', {
On 2013/10/01 17:49:38, borenet wrote:
> This line can also just be:
> 
> [ 'skia_sanitizer', {

Done.

https://codereview.chromium.org/25564003/diff/6001/gyp/common_variables.gypi
File gyp/common_variables.gypi (right):

https://codereview.chromium.org/25564003/diff/6001/gyp/common_variables.gypi#...
gyp/common_variables.gypi:121: [ 'skia_sanitizer != ""', {
On 2013/10/01 17:49:38, borenet wrote:
> Again, can just use 'skia_sanitizer'

Done.

https://codereview.chromium.org/25564003/diff/6001/gyp/common_variables.gypi#...
gyp/common_variables.gypi:122: 'skia_clang_build': 1,   # What's the difference
between skia_clang_build and skia_clang_build%?
On 2013/10/01 17:49:38, borenet wrote:
> The % at the end of the variable means that we're conditionally assigning it. 
> For this if/else in particular, we want to *override* skia_clang_build if
we're
> doing a *san build, so we avoid using the '%'.

Ah!  Gotcha.

[borenet, 2013-10-01 17:55:31]

LGTM pending buildbot-side changes.

[mtklein, 2013-10-08 15:16:39]

Committed patchset #4 manually as r11648.