Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: gyp/common_conditions.gypi

Issue 25564003: skia/trunk changes for generic sanitizer gyp flag. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: borenet Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gyp/common_variables.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/common_conditions.gypi
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi
index f8012b99d5344347131598e7eaaeb6918f4452e2..1cbdd7b45a62b79c7572f94fb56e031b3ffd0e29 100644
--- a/gyp/common_conditions.gypi
+++ b/gyp/common_conditions.gypi
@@ -277,26 +277,19 @@
}],
],
}],
- [ 'skia_asan_build', {
+ # Enable asan, tsan, etc.
+ [ 'skia_sanitizer', {
'cflags': [
- '-fsanitize=address',
+ '-fsanitize=<(skia_sanitizer)',
'-fno-omit-frame-pointer',
],
'ldflags': [
- '-fsanitize=address',
- ],
- }],
- [ 'skia_tsan_build', {
- 'cflags': [
- '-fsanitize=thread',
- '-fno-omit-frame-pointer',
- ],
- 'ldflags': [
- '-fsanitize=thread',
+ '-fsanitize=<(skia_sanitizer)',
],
}],
[ 'skia_clang_build', {
'cflags': [
+ # Extra warnings we like but that only Clang knows about.
'-Wstring-conversion',
],
}],
« no previous file with comments | « no previous file | gyp/common_variables.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698