Ensure Char events sent to pepper indicate the correct timestamp seconds.

Ensure Char events sent to pepper indicate the correct timestamp seconds.

Previously the wall clock was being used but really it should be
the realtime clock.

BUG=625680
Committed: https://crrev.com/dbb3776482cac31616c9309bf727c594a1653e2e
Cr-Commit-Position: refs/heads/master@{#437541}

[dtapuska, 2016-12-08 16:53:48]

dtapuska@chromium.org changed reviewers:
+ clamy@chromium.org, majidvp@chromium.org

[dtapuska, 2016-12-08 16:54:04]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 16:54:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 18:15:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 18:15:32]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[majidvp, 2016-12-08 20:26:33]

lgtm with nit.

https://codereview.chromium.org/2556353003/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2556353003/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.cc:6467: (base::TimeTicks::Now() -
base::TimeTicks()).InSecondsF();
nit: Please use ui::EventTimeStampToSeconds to make the conversion to seconds.
Also you might as well use ui::EventTimeForNow() which allows proper mocking of
time during tests.

[dtapuska, 2016-12-08 20:56:38]

On 2016/12/08 20:26:33, majidvp wrote:
> lgtm with nit.
> 
>
https://codereview.chromium.org/2556353003/diff/1/content/renderer/render_fra...
> File content/renderer/render_frame_impl.cc (right):
> 
>
https://codereview.chromium.org/2556353003/diff/1/content/renderer/render_fra...
> content/renderer/render_frame_impl.cc:6467: (base::TimeTicks::Now() -
> base::TimeTicks()).InSecondsF();
> nit: Please use ui::EventTimeStampToSeconds to make the conversion to seconds.
> Also you might as well use ui::EventTimeForNow() which allows proper mocking
of
> time during tests.

done

[clamy, 2016-12-09 14:30:19]

Thanks! Lgtm.

[dtapuska, 2016-12-09 14:31:17]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-12-09 14:31:17]

The patchset sent to the CQ was uploaded after l-g-t-m from majidvp@chromium.org
Link to the patchset: https://codereview.chromium.org/2556353003/#ps20001
(title: "Use alternate API")

[commit-bot: I haz the power, 2016-12-09 14:31:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 15:17:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481293877354540,
"parent_rev": "c1b107d0735a092e6b2940c5047b62309a43ff26", "commit_rev":
"5c3da3dcd60d8f6951143f654d542a26862ea7d1"}

[commit-bot: I haz the power, 2016-12-09 15:17:49]

Description was changed from

==========
Ensure Char events sent to pepper indicate the correct timestamp seconds.

Previously the wall clock was being used but really it should be
the realtime clock.

BUG=625680
==========

to

==========
Ensure Char events sent to pepper indicate the correct timestamp seconds.

Previously the wall clock was being used but really it should be
the realtime clock.

BUG=625680

Review-Url: https://codereview.chromium.org/2556353003
==========

[commit-bot: I haz the power, 2016-12-09 15:17:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-09 15:20:25]

Description was changed from

==========
Ensure Char events sent to pepper indicate the correct timestamp seconds.

Previously the wall clock was being used but really it should be
the realtime clock.

BUG=625680

Review-Url: https://codereview.chromium.org/2556353003
==========

to

==========
Ensure Char events sent to pepper indicate the correct timestamp seconds.

Previously the wall clock was being used but really it should be
the realtime clock.

BUG=625680

Committed: https://crrev.com/dbb3776482cac31616c9309bf727c594a1653e2e
Cr-Commit-Position: refs/heads/master@{#437541}
==========

[commit-bot: I haz the power, 2016-12-09 15:20:27]

Patchset 2 (id:??) landed as
https://crrev.com/dbb3776482cac31616c9309bf727c594a1653e2e
Cr-Commit-Position: refs/heads/master@{#437541}