Detect change on video/viewport intersection when rendered remotely

third_party/WebKit/public/platform/WebMediaPlayerClient.h

Index: third_party/WebKit/public/platform/WebMediaPlayerClient.h
diff --git a/third_party/WebKit/public/platform/WebMediaPlayerClient.h b/third_party/WebKit/public/platform/WebMediaPlayerClient.h
index cb9807e61d05415ebb15cea35f0ac151335c4ce9..e5fada833ef46634dd121fe6ed3ea7d0ddeeb492 100644
--- a/third_party/WebKit/public/platform/WebMediaPlayerClient.h
+++ b/third_party/WebKit/public/platform/WebMediaPlayerClient.h
@@ -94,6 +94,7 @@ class BLINK_PLATFORM_EXPORT WebMediaPlayerClient {
   virtual void disconnectedFromRemoteDevice() = 0;
   virtual void cancelledRemotePlaybackRequest() = 0;
   virtual void remotePlaybackStarted() = 0;
+  virtual void activateViewportIntersectionMonitoring(bool) {}

[xhwang, 2016/12/15 04:10:23]

Sorry for the delay. To me, "activate" is pretty much the same as "enable"...
updateViewportIntersectionMonitoring(ENABLE) would be more clear but isn't
perfect either. So it's up to you.

I agree comments like "activate viewport intersection monitoring" would be
redundant. But for this particular one, if I am going to implement
WebMediaPlayer interface, I really have now idea when I should "activate or
deactivate viewport intersection". If I activate it, what will happen? Will I
get any notification if viewport intersection actually changed?

Also, this is the only method on this interface that's not pure virtual. Any
reason for that? Should we be consistent with other existing methods?

[xjz, 2016/12/15 20:00:33]

Thanks. Added comments to explain what this is currently used for. PTAL

As for naming, I prefer the current one as it sounds more like a control method.

 
   // Returns whether the media element is in an autoplay muted state.
   virtual bool isAutoplayingMuted() = 0;