Detect change on video/viewport intersection when rendered remotely

third_party/WebKit/public/platform/WebMediaPlayerClient.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 76 matching lines @@
   virtual void addTextTrack(WebInbandTextTrack*) = 0;
   virtual void removeTextTrack(WebInbandTextTrack*) = 0;
   virtual void mediaSourceOpened(WebMediaSource*) = 0;
   virtual void requestSeek(double) = 0;
   virtual void remoteRouteAvailabilityChanged(
       WebRemotePlaybackAvailability) = 0;
   virtual void connectedToRemoteDevice() = 0;
   virtual void disconnectedFromRemoteDevice() = 0;
   virtual void cancelledRemotePlaybackRequest() = 0;
   virtual void remotePlaybackStarted() = 0;
+  virtual void activateViewportIntersectionMonitoring(bool) {}

[xhwang, 2016/12/15 04:10:23]

Sorry for the delay. To me, "activate" is pretty much the same as "enable"...
updateViewportIntersectionMonitoring(ENABLE) would be more clear but isn't
perfect either. So it's up to you.

I agree comments like "activate viewport intersection monitoring" would be
redundant. But for this particular one, if I am going to implement
WebMediaPlayer interface, I really have now idea when I should "activate or
deactivate viewport intersection". If I activate it, what will happen? Will I
get any notification if viewport intersection actually changed?

Also, this is the only method on this interface that's not pure virtual. Any
reason for that? Should we be consistent with other existing methods?

[xjz, 2016/12/15 20:00:33]

Thanks. Added comments to explain what this is currently used for. PTAL

As for naming, I prefer the current one as it sounds more like a control method.

 
   // Returns whether the media element is in an autoplay muted state.
   virtual bool isAutoplayingMuted() = 0;
 
   // Warning: This method will destruct the caller.
   virtual void requestReload(const WebURL& newUrl) = 0;
 
   // Returns if there's a selected video track.
   virtual bool hasSelectedVideoTrack() = 0;
 
   // Returns the selected video track id (or an empty id if there's none).
   virtual WebMediaPlayer::TrackId getSelectedVideoTrackId() = 0;
 
  protected:
   ~WebMediaPlayerClient() {}
 };
 
 }  // namespace blink
 
 #endif