Detect change on video/viewport intersection when rendered remotely

third_party/WebKit/public/platform/WebMediaPlayerClient.h

Index: third_party/WebKit/public/platform/WebMediaPlayerClient.h
diff --git a/third_party/WebKit/public/platform/WebMediaPlayerClient.h b/third_party/WebKit/public/platform/WebMediaPlayerClient.h
index cb9807e61d05415ebb15cea35f0ac151335c4ce9..b81d629b28569f19c060abc5d44a8353c73f2773 100644
--- a/third_party/WebKit/public/platform/WebMediaPlayerClient.h
+++ b/third_party/WebKit/public/platform/WebMediaPlayerClient.h
@@ -94,6 +94,7 @@ class BLINK_PLATFORM_EXPORT WebMediaPlayerClient {
   virtual void disconnectedFromRemoteDevice() = 0;
   virtual void cancelledRemotePlaybackRequest() = 0;
   virtual void remotePlaybackStarted() = 0;
+  virtual void enableMonitorViewportIntersection(bool) {}

[xhwang, 2016/12/14 18:11:41]

I know blink/webkit doesn't like comments, but IMHO this new API is really hard
to understand. Will we always "enable" but use the "bool" as auxiliary info? Or
will we actually "disable" when the "bool" is false?

Since we already have interfaces methods with nice comments (see below), can we
follow that style?

[xhwang, 2016/12/14 18:11:41]

BTW, I am not a fan of using enableFoo(false) to disable Foo... How about:

viewportIntersectionMonitorStateChanged(bool enable)

[miu, 2016/12/14 19:15:50]

No, that wouldn't be right: This is a control method, not an observer callback.

Though, you do make a good point about the namong being a little confusing. How
about activateViewportIntersectionMonitoring()?

[ojan, 2016/12/14 21:00:56]

Just want to clarify: Blink has no policy against comments. Comments that
explain "why" code is doing something non-obvious are always welcome. For
comments that explain "what" the code is doing is something more like: "Use
descriptive names for methods and avoid comments that just state relatively
clear implications of what the method is doing based off the name." This is
consistent with the spirit of the Google C++ style guide
(https://google.github.io/styleguide/cppguide.html#Function_Comments), but has a
different opinion on what counts as "simple and obvious."

For example, the following would be a comment to leave out because it provides
no value over the obvious meaning of the name.

// Activates viewport intersection monitoring. True value means activated.
virtual void activateViewportIntersectionMonitoring(bool) {}

[xjz, 2016/12/15 00:01:41]

Thanks miu and ojan. Took the suggestion, and renamed this as
"activateViewportIntersectionMonitoring". 

 
   // Returns whether the media element is in an autoplay muted state.
   virtual bool isAutoplayingMuted() = 0;