third_party/WebKit/Source/web/tests/MediaElementFillingViewportTest.cpp - Issue 2556333002: Detect change on video/viewport intersection when rendered remotely

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/MediaElementFillingViewportTest.cpp

Issue 2556333002: Detect change on video/viewport intersection when rendered remotely (Closed)

Patch Set: Addressed ojan's comment. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/blink/webmediaplayer_impl.h ('K') | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | third_party/WebKit/public/platform/WebMediaPlayerClient.h » ('j') | third_party/WebKit/public/platform/WebMediaPlayerClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/MediaElementFillingViewportTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/MediaElementFillingViewportTest.cpp b/third_party/WebKit/Source/web/tests/MediaElementFillingViewportTest.cpp

index 5378c0ba16128a9e06cc4bd29aa6416aaf29c6ed..c9c8933cd4cbf76b72499f6964338e71a4fa03ab 100644

--- a/third_party/WebKit/Source/web/tests/MediaElementFillingViewportTest.cpp

+++ b/third_party/WebKit/Source/web/tests/MediaElementFillingViewportTest.cpp

@@ -26,7 +26,10 @@ class MediaElementFillingViewportTest : public SimTest {

}

void checkViewportIntersectionChanged(HTMLMediaElement* element) {

- element->checkViewportIntersectionChanged();

+ element->enableMonitorViewportIntersection(true);

+ EXPECT_TRUE(element->m_checkViewportIntersectionTimer.isActive());

+ // TODO(xjz): Mock the time and wait for 1s instead.

+ element->checkViewportIntersectionTimerFired(nullptr);

}

std::unique_ptr<SimRequest> createMainResource() {