Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2556253009:
Remove GYP support from create_installer_archive.py (Closed)
DescriptionRemove GYP support from create_installer_archive.py
The component build copier can always rely on having runtime deps
available.
BUG=586967
Committed: https://crrev.com/890d09b2e0eaad54e3f274b987e4e78fb078ec31
Cr-Commit-Position: refs/heads/master@{#437890}
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 22 (15 generated)
The CQ bit was checked by jbauman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by jbauman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
jbauman@chromium.org changed reviewers: + gab@chromium.org
lgtm, thanks
The CQ bit was checked by gab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove GYP support from create_installer_archive.py The component build copier can always rely on having runtime deps available. ========== to ========== Remove GYP support from create_installer_archive.py The component build copier can always rely on having runtime deps available. BUG=586967 ==========
On 2016/12/12 16:19:08, gab wrote: > lgtm, thanks Associated with BUG=586967 and CQ'ed :)
sebmarchand@chromium.org changed reviewers: + sebmarchand@chromium.org
Thanks! I was going to address this in https://codereview.chromium.org/2559053002/ but I had no idea of what I was doing :)
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481559551008250,
"parent_rev": "2f2b6c13c99caf5a300f3c8aeb44e466a8faa514", "commit_rev":
"28a2683cea5100083788045ba22812926e1ec74c"}
Message was sent while issue was closed.
Description was changed from ========== Remove GYP support from create_installer_archive.py The component build copier can always rely on having runtime deps available. BUG=586967 ========== to ========== Remove GYP support from create_installer_archive.py The component build copier can always rely on having runtime deps available. BUG=586967 Review-Url: https://codereview.chromium.org/2556253009 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove GYP support from create_installer_archive.py The component build copier can always rely on having runtime deps available. BUG=586967 Review-Url: https://codereview.chromium.org/2556253009 ========== to ========== Remove GYP support from create_installer_archive.py The component build copier can always rely on having runtime deps available. BUG=586967 Committed: https://crrev.com/890d09b2e0eaad54e3f274b987e4e78fb078ec31 Cr-Commit-Position: refs/heads/master@{#437890} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/890d09b2e0eaad54e3f274b987e4e78fb078ec31 Cr-Commit-Position: refs/heads/master@{#437890} |
