Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1653)

Unified Diff: chrome/browser/resources/settings/internet_page/internet_page.html

Issue 2556253007: MD Settings: Fix internet focus and styling (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/internet_page.html
diff --git a/chrome/browser/resources/settings/internet_page/internet_page.html b/chrome/browser/resources/settings/internet_page/internet_page.html
index 21a0d91152ac7cd99e65657269f258a302d3569b..3eb96b1734f4bb4da65a73c5660ab5009d16eadd 100644
--- a/chrome/browser/resources/settings/internet_page/internet_page.html
+++ b/chrome/browser/resources/settings/internet_page/internet_page.html
@@ -1,3 +1,4 @@
+<link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expand_button.html">
<link rel="import" href="chrome://resources/cr_elements/icons.html">
<link rel="import" href="chrome://resources/cr_elements/network/cr_onc_types.html">
<link rel="import" href="chrome://resources/html/i18n_behavior.html">
@@ -46,11 +47,17 @@
<template is="dom-if" if="[[addConnectionExpanded_]]">
<div actionable class="settings-box continuation center"
on-tap="onAddWiFiTap_">
- <div class="start add-no-icon">$i18n{internetAddWiFi}</div>
+ <div class="start add-no-icon" actionable>
Dan Beam 2016/12/09 00:11:38 how is this actionable? what does it do? this lo
stevenjb 2016/12/09 00:57:52 You're right, it was leftover from an intermediate
+ $i18n{internetAddWiFi}
+ </div>
+ <button class="icon-external" is="paper-icon-button-light"></button>
dschuyler 2016/12/09 01:15:52 Should there be a: <link rel="import" href="chrome
stevenjb 2016/12/09 01:29:30 Yes. Done.
</div>
<div actionable class="settings-box continuation center"
on-tap="onAddVPNTap_">
- <div class="start add-no-icon">$i18n{internetAddVPN}</div>
+ <div class="start add-no-icon" actionable>
Dan Beam 2016/12/09 00:11:38 same
stevenjb 2016/12/09 00:57:52 Done.
+ $i18n{internetAddVPN}
+ </div>
+ <button class="icon-external" is="paper-icon-button-light"></button>
</div>
<template is="dom-repeat" items="[[thirdPartyVpnProviders_]]">
<div actionable class="settings-box continuation center"

Powered by Google App Engine
This is Rietveld 408576698