Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <link rel="import" href="chrome://resources/cr_elements/cr_expand_button/cr_expa nd_button.html"> | |
| 1 <link rel="import" href="chrome://resources/cr_elements/icons.html"> | 2 <link rel="import" href="chrome://resources/cr_elements/icons.html"> |
| 2 <link rel="import" href="chrome://resources/cr_elements/network/cr_onc_types.htm l"> | 3 <link rel="import" href="chrome://resources/cr_elements/network/cr_onc_types.htm l"> |
| 3 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> | 4 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> |
| 4 <link rel="import" href="chrome://resources/html/polymer.html"> | 5 <link rel="import" href="chrome://resources/html/polymer.html"> |
| 5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l"> | 6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l"> |
| 6 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html"> | 7 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html"> |
| 7 <link rel="import" href="/prefs/prefs.html"> | 8 <link rel="import" href="/prefs/prefs.html"> |
| 8 <link rel="import" href="/route.html"> | 9 <link rel="import" href="/route.html"> |
| 9 <link rel="import" href="/settings_page/settings_animated_pages.html"> | 10 <link rel="import" href="/settings_page/settings_animated_pages.html"> |
| 10 <link rel="import" href="/settings_page/settings_subpage.html"> | 11 <link rel="import" href="/settings_page/settings_subpage.html"> |
| (...skipping 28 matching lines...) Expand all Loading... | |
| 39 <iron-icon icon="cr:add"></iron-icon> | 40 <iron-icon icon="cr:add"></iron-icon> |
| 40 <div>$i18n{internetAddConnection}</div> | 41 <div>$i18n{internetAddConnection}</div> |
| 41 </div> | 42 </div> |
| 42 <cr-expand-button alt="$i18n{internetAddConnectionExpandA11yLabel}" | 43 <cr-expand-button alt="$i18n{internetAddConnectionExpandA11yLabel}" |
| 43 id="expandAddConnections" expanded="{{addConnectionExpanded_}}"> | 44 id="expandAddConnections" expanded="{{addConnectionExpanded_}}"> |
| 44 </cr-expand-button> | 45 </cr-expand-button> |
| 45 </div> | 46 </div> |
| 46 <template is="dom-if" if="[[addConnectionExpanded_]]"> | 47 <template is="dom-if" if="[[addConnectionExpanded_]]"> |
| 47 <div actionable class="settings-box continuation center" | 48 <div actionable class="settings-box continuation center" |
| 48 on-tap="onAddWiFiTap_"> | 49 on-tap="onAddWiFiTap_"> |
| 49 <div class="start add-no-icon">$i18n{internetAddWiFi}</div> | 50 <div class="start add-no-icon" actionable> |
|
Dan Beam
2016/12/09 00:11:38
how is this actionable? what does it do? this lo
stevenjb
2016/12/09 00:57:52
You're right, it was leftover from an intermediate
| |
| 51 $i18n{internetAddWiFi} | |
| 52 </div> | |
| 53 <button class="icon-external" is="paper-icon-button-light"></button> | |
|
dschuyler
2016/12/09 01:15:52
Should there be a:
<link rel="import" href="chrome
stevenjb
2016/12/09 01:29:30
Yes. Done.
| |
| 50 </div> | 54 </div> |
| 51 <div actionable class="settings-box continuation center" | 55 <div actionable class="settings-box continuation center" |
| 52 on-tap="onAddVPNTap_"> | 56 on-tap="onAddVPNTap_"> |
| 53 <div class="start add-no-icon">$i18n{internetAddVPN}</div> | 57 <div class="start add-no-icon" actionable> |
|
Dan Beam
2016/12/09 00:11:38
same
stevenjb
2016/12/09 00:57:52
Done.
| |
| 58 $i18n{internetAddVPN} | |
| 59 </div> | |
| 60 <button class="icon-external" is="paper-icon-button-light"></button> | |
| 54 </div> | 61 </div> |
| 55 <template is="dom-repeat" items="[[thirdPartyVpnProviders_]]"> | 62 <template is="dom-repeat" items="[[thirdPartyVpnProviders_]]"> |
| 56 <div actionable class="settings-box continuation center" | 63 <div actionable class="settings-box continuation center" |
| 57 on-tap="onAddThirdPartyVpnTap_" provider="[[item]]"> | 64 on-tap="onAddThirdPartyVpnTap_" provider="[[item]]"> |
| 58 <div class="start add-no-icon"> | 65 <div class="start add-no-icon"> |
| 59 [[getAddThirdParrtyVpnLabel_(item)]] | 66 [[getAddThirdParrtyVpnLabel_(item)]] |
| 60 </div> | 67 </div> |
| 61 </div> | 68 </div> |
| 62 </template> | 69 </template> |
| 63 </template> | 70 </template> |
| (...skipping 12 matching lines...) Expand all Loading... | |
| 76 network-type="[[knownNetworksType_]]" | 83 network-type="[[knownNetworksType_]]" |
| 77 on-show-detail="onShowDetail_" | 84 on-show-detail="onShowDetail_" |
| 78 networking-private="[[networkingPrivate]]"> | 85 networking-private="[[networkingPrivate]]"> |
| 79 </settings-internet-known-networks-page> | 86 </settings-internet-known-networks-page> |
| 80 </settings-subpage> | 87 </settings-subpage> |
| 81 </template> | 88 </template> |
| 82 </settings-animated-pages> | 89 </settings-animated-pages> |
| 83 </template> | 90 </template> |
| 84 <script src="internet_page.js"></script> | 91 <script src="internet_page.js"></script> |
| 85 </dom-module> | 92 </dom-module> |
| OLD | NEW |