Removing trace_data from our chrome telemetry build dependency list.

Removing trace_data from our chrome telemetry build dependency list.

BUG=chromium:670284
Committed: https://crrev.com/7ff018563d1f7b78d5906e7478858f8931724693
Cr-Commit-Position: refs/heads/master@{#437896}

[eyaich1, 2016-12-07 18:16:34]

eyaich@chromium.org changed reviewers:
+ eakuefner@chromium.org, nednguyen@google.com

[eyaich1, 2016-12-07 18:16:34]

eyaich@chromium.org changed reviewers:
+ eakuefner@chromium.org, nednguyen@google.com

[sullivan, 2016-12-07 18:22:56]

sullivan@chromium.org changed reviewers:
+ sullivan@chromium.org

[sullivan, 2016-12-07 18:22:56]

So we will need to update this list every time we add a directory to catapult?
And will things move if we remove a directory from catapult?

+nduca, benjhayden: should we reconsider moving the very large files here to a
separate repo? See
https://github.com/catapult-project/catapult/issues/1933#issuecomment-229436870

[nednguyen, 2016-12-07 18:23:43]

This can be fragile. The right thing here is to purge the tracing/test_data from
catapult directly & move it to another catapult github repo

[eakuefner, 2016-12-07 18:27:02]

eakuefner@chromium.org changed reviewers:
+ aiolos@chromium.org

[eakuefner, 2016-12-07 18:27:03]

+aiolos

Open bug that is tracking test_data migration:
https://github.com/catapult-project/catapult/issues/1933

[eyaich1, 2016-12-09 14:18:47]

On 2016/12/07 18:27:03, eakuefner wrote:
> +aiolos
> 
> Open bug that is tracking test_data migration:
> https://github.com/catapult-project/catapult/issues/1933

So one of our only courses of action on the Mac HDD swarmed bots is to try and
reduce the number of inputs to the isolate:
https://bugs.chromium.org/p/chromium/issues/detail?id=670284#c25  

I would like to use this CL as a test to see where reducing the size can get us
in terms of executed jobs.  I realize this is not a long term solution as it is
very brittle.

[nednguyen, 2016-12-09 14:19:55]

On 2016/12/09 14:18:47, eyaich1 wrote:
> On 2016/12/07 18:27:03, eakuefner wrote:
> > +aiolos
> > 
> > Open bug that is tracking test_data migration:
> > https://github.com/catapult-project/catapult/issues/1933
> 
> So one of our only courses of action on the Mac HDD swarmed bots is to try and
> reduce the number of inputs to the isolate:
> https://bugs.chromium.org/p/chromium/issues/detail?id=670284#c25  
> 
> I would like to use this CL as a test to see where reducing the size can get
us
> in terms of executed jobs.  I realize this is not a long term solution as it
is
> very brittle.

ok for testing

lgtm

[nednguyen, 2016-12-09 14:20:47]

On 2016/12/09 14:19:55, nednguyen wrote:
> On 2016/12/09 14:18:47, eyaich1 wrote:
> > On 2016/12/07 18:27:03, eakuefner wrote:
> > > +aiolos
> > > 
> > > Open bug that is tracking test_data migration:
> > > https://github.com/catapult-project/catapult/issues/1933
> > 
> > So one of our only courses of action on the Mac HDD swarmed bots is to try
and
> > reduce the number of inputs to the isolate:
> > https://bugs.chromium.org/p/chromium/issues/detail?id=670284#c25  
> > 
> > I would like to use this CL as a test to see where reducing the size can get
> us
> > in terms of executed jobs.  I realize this is not a long term solution as it
> is
> > very brittle.
> 
> ok for testing
> 
> lgtm

please revert the CL right after you can verify whether this actually helps

[eyaich1, 2016-12-09 14:26:58]

The CQ bit was checked by eyaich@chromium.org

[commit-bot: I haz the power, 2016-12-09 14:27:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 15:39:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 15:39:59]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[eyaich1, 2016-12-12 15:40:23]

The CQ bit was checked by eyaich@chromium.org

[eyaich1, 2016-12-12 15:40:23]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2556193002/#ps40001
(title: "Removing local files")

[commit-bot: I haz the power, 2016-12-12 15:40:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 17:49:52]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481557223292680,
"parent_rev": "43984c675675bd0f31f2b3fc647bfa819c862cea", "commit_rev":
"f7430cf5413cb28aa45599823939811221db2964"}

[commit-bot: I haz the power, 2016-12-12 17:50:21]

Description was changed from

==========
Removing trace_data from our chrome telemetry build dependency list.

BUG=chromium:670284
==========

to

==========
Removing trace_data from our chrome telemetry build dependency list.

BUG=chromium:670284

Review-Url: https://codereview.chromium.org/2556193002
==========

[commit-bot: I haz the power, 2016-12-12 17:50:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-12 17:52:55]

Description was changed from

==========
Removing trace_data from our chrome telemetry build dependency list.

BUG=chromium:670284

Review-Url: https://codereview.chromium.org/2556193002
==========

to

==========
Removing trace_data from our chrome telemetry build dependency list.

BUG=chromium:670284

Committed: https://crrev.com/7ff018563d1f7b78d5906e7478858f8931724693
Cr-Commit-Position: refs/heads/master@{#437896}
==========

[commit-bot: I haz the power, 2016-12-12 17:52:56]

Patchset 3 (id:??) landed as
https://crrev.com/7ff018563d1f7b78d5906e7478858f8931724693
Cr-Commit-Position: refs/heads/master@{#437896}

[eyaich1, 2016-12-14 17:22:28]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2569763005/ by eyaich@chromium.org.

The reason for reverting is: Was only for testing purposes.