[Extensions] Convert more callers of CallModuleMethod

[Extensions] Convert more callers of CallModuleMethod

ModuleSystem::CallModuleMethod is deprecated (see bug for more info).
Convert some callers to use ModuleSystem::CallModuleMethodSafe.
Some callers need the results from the JS call, so introduce a
callback to the safe versions of CallModuleMethod and CallFunction.

BUG=629431
Committed: https://crrev.com/0d94256f8ece8ddbb5f3a5c01b31fa42942ef5e7
Cr-Commit-Position: refs/heads/master@{#437545}

[Devlin, 2016-12-07 17:19:39]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 17:20:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-12-07 17:56:03]

Description was changed from

==========
woot


fix

BUG=
==========

to

==========
[Extensions] Convert more callers of CallModuleMethod

ModuleSystem::CallModuleMethod is deprecated (see bug for more info).
Convert some callers to use ModuleSystem::CallModuleMethodSafe.
Some callers need the results from the JS call, so introduce a
callback to the safe versions of CallModuleMethod and CallFunction.

BUG=629431
==========

[commit-bot: I haz the power, 2016-12-07 18:42:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 18:42:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2016-12-07 19:31:09]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 19:32:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-12-07 19:37:34]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 19:37:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 20:43:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 20:43:38]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-12-07 20:57:53]

Patchset #2 (id:20001) has been deleted

[Devlin, 2016-12-07 20:58:00]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-12-07 20:58:10]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[lazyboy, 2016-12-07 22:48:51]

lgtm with one nit

https://codereview.chromium.org/2556153002/diff/40001/extensions/renderer/scr...
File extensions/renderer/script_context.h (right):

https://codereview.chromium.org/2556153002/diff/40001/extensions/renderer/scr...
extensions/renderer/script_context.h:121: // USE THIS METHOD RATHER THAN
v8::Function::Call WHEREVER POSSIBLE.
THESE METHODS

[Devlin, 2016-12-08 19:08:03]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 19:09:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 20:18:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 20:19:00]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-12-08 20:55:07]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-12-08 20:55:07]

The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2556153002/#ps50001
(title: "nit")

[Devlin, 2016-12-08 20:55:09]

The CQ bit was unchecked by rdevlin.cronin@chromium.org

[Devlin, 2016-12-08 20:55:15]

The CQ bit was unchecked by rdevlin.cronin@chromium.org

[Devlin, 2016-12-08 21:54:59]

Patchset #3 (id:70001) has been deleted

[Devlin, 2016-12-08 21:55:09]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 21:55:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 23:15:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 23:15:22]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-12-09 15:28:42]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-12-09 15:28:43]

The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2556153002/#ps90001
(title: "revert doc change")

[commit-bot: I haz the power, 2016-12-09 15:29:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 15:34:28]

CQ is committing da patch.

Bot data: {"patchset_id": 90001, "attempt_start_ts": 1481297322974320,
"parent_rev": "e916413c4bd7ff847dcb778dba491c34af13503b", "commit_rev":
"06534dde6407e76882d91977564b0647b59f09a5"}

[commit-bot: I haz the power, 2016-12-09 15:34:52]

Description was changed from

==========
[Extensions] Convert more callers of CallModuleMethod

ModuleSystem::CallModuleMethod is deprecated (see bug for more info).
Convert some callers to use ModuleSystem::CallModuleMethodSafe.
Some callers need the results from the JS call, so introduce a
callback to the safe versions of CallModuleMethod and CallFunction.

BUG=629431
==========

to

==========
[Extensions] Convert more callers of CallModuleMethod

ModuleSystem::CallModuleMethod is deprecated (see bug for more info).
Convert some callers to use ModuleSystem::CallModuleMethodSafe.
Some callers need the results from the JS call, so introduce a
callback to the safe versions of CallModuleMethod and CallFunction.

BUG=629431

Review-Url: https://codereview.chromium.org/2556153002
==========

[commit-bot: I haz the power, 2016-12-09 15:34:54]

Committed patchset #3 (id:90001)

[commit-bot: I haz the power, 2016-12-09 15:37:14]

Description was changed from

==========
[Extensions] Convert more callers of CallModuleMethod

ModuleSystem::CallModuleMethod is deprecated (see bug for more info).
Convert some callers to use ModuleSystem::CallModuleMethodSafe.
Some callers need the results from the JS call, so introduce a
callback to the safe versions of CallModuleMethod and CallFunction.

BUG=629431

Review-Url: https://codereview.chromium.org/2556153002
==========

to

==========
[Extensions] Convert more callers of CallModuleMethod

ModuleSystem::CallModuleMethod is deprecated (see bug for more info).
Convert some callers to use ModuleSystem::CallModuleMethodSafe.
Some callers need the results from the JS call, so introduce a
callback to the safe versions of CallModuleMethod and CallFunction.

BUG=629431

Committed: https://crrev.com/0d94256f8ece8ddbb5f3a5c01b31fa42942ef5e7
Cr-Commit-Position: refs/heads/master@{#437545}
==========

[commit-bot: I haz the power, 2016-12-09 15:37:15]

Patchset 3 (id:??) landed as
https://crrev.com/0d94256f8ece8ddbb5f3a5c01b31fa42942ef5e7
Cr-Commit-Position: refs/heads/master@{#437545}