Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 255613002: Add detail to 'invalid JSON' message in PRESUBMIT.py. (Closed)

Created:
6 years, 8 months ago by Thiemo Nagel
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@policy-list-doc
Visibility:
Public.

Description

Add detail to 'invalid JSON' message in PRESUBMIT.py. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M PRESUBMIT.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Thiemo Nagel
Hi Jochen, could you please have a look at this small improvement? Thank you! Thiemo
6 years, 8 months ago (2014-04-24 12:54:50 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-24 13:01:00 UTC) #2
Thiemo Nagel
On 2014/04/24 13:01:00, jochen wrote: > lgtm Thank you!
6 years, 8 months ago (2014-04-24 13:05:52 UTC) #3
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 8 months ago (2014-04-24 13:05:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/255613002/1
6 years, 8 months ago (2014-04-24 13:48:33 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 14:20:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_compile_dbg
6 years, 8 months ago (2014-04-24 14:20:36 UTC) #7
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 8 months ago (2014-04-24 16:35:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/255613002/1
6 years, 8 months ago (2014-04-24 16:37:44 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 22:55:22 UTC) #10
Message was sent while issue was closed.
Change committed as 266019

Powered by Google App Engine
This is Rietveld 408576698