PRESUBMIT.py - Issue 255613002: Add detail to 'invalid JSON' message in PRESUBMIT.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 255613002: Add detail to 'invalid JSON' message in PRESUBMIT.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@policy-list-doc

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 8a6454358882c90b10928d80b7300d602e7f01c6..3c1b7ff9fde749fa54dd63239a193a5090878ded 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -1069,9 +1069,10 @@ def _CheckJSONParsability(input_api, output_api):

with open(fpath.LocalPath(), 'r') as f:

try:

input_api.json.load(f)

- except ValueError:

+ except ValueError as e:

results.append(output_api.PresubmitError(

- "File %r does not parse as valid JSON" % (fpath.LocalPath())

+ "File %r does not parse as valid JSON:\n %s"

+ % (fpath.LocalPath(), e.args[0])

))

return results

« no previous file with comments | « no previous file | no next file » | no next file with comments »