Don't subtract border from max size for display rect.

Don't subtract border from max size for display rect.

The display rect must be consistent with max size,
otherwise the text may not fit.

BUG=664370
TEST=TooltipControllerTest.TestMaxWidth

Committed: https://crrev.com/8658c9c6854e1a550d2adc155cb17dc8ed39e62c
Cr-Commit-Position: refs/heads/master@{#440337}

[oshima, 2016-12-07 16:13:37]

Patchset #1 (id:1) has been deleted

[oshima, 2016-12-07 16:13:53]

oshima@chromium.org changed reviewers:
+ sky@chromium.org, warx@chromium.org

[sky, 2016-12-07 17:09:37]

https://codereview.chromium.org/2556083002/diff/20001/ui/gfx/render_text.h
File ui/gfx/render_text.h (right):

https://codereview.chromium.org/2556083002/diff/20001/ui/gfx/render_text.h#ne...
ui/gfx/render_text.h:532: size_t line_size_for_test() const { return
lines_.size(); }
Add to test::RenderTextTestApi ?

[Qiang(Joe) Xu, 2016-12-07 17:37:15]

On 2016/12/07 16:13:53, oshima wrote:

lgtm, thanks, I didn't realize that the bug is in the displaying of
render_text_.

[oshima, 2016-12-13 14:22:19]

https://codereview.chromium.org/2556083002/diff/20001/ui/gfx/render_text.h
File ui/gfx/render_text.h (right):

https://codereview.chromium.org/2556083002/diff/20001/ui/gfx/render_text.h#ne...
ui/gfx/render_text.h:532: size_t line_size_for_test() const { return
lines_.size(); }
On 2016/12/07 17:09:37, sky wrote:
> Add to test::RenderTextTestApi ?

Extracted to a separate file. PTAL.

[sky, 2016-12-13 17:48:31]

LGTM

https://codereview.chromium.org/2556083002/diff/40001/ui/gfx/test/render_text...
File ui/gfx/test/render_text_test_api.h (right):

https://codereview.chromium.org/2556083002/diff/40001/ui/gfx/test/render_text...
ui/gfx/test/render_text_test_api.h:21: RenderTextTestApi(RenderText*
render_text) : render_text_(render_text) {}
explicit

[oshima, 2016-12-13 21:18:02]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[oshima, 2016-12-13 21:18:12]

https://codereview.chromium.org/2556083002/diff/40001/ui/gfx/test/render_text...
File ui/gfx/test/render_text_test_api.h (right):

https://codereview.chromium.org/2556083002/diff/40001/ui/gfx/test/render_text...
ui/gfx/test/render_text_test_api.h:21: RenderTextTestApi(RenderText*
render_text) : render_text_(render_text) {}
On 2016/12/13 17:48:31, sky wrote:
> explicit

Done.

[commit-bot: I haz the power, 2016-12-13 21:18:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 21:24:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 21:24:50]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2016-12-13 22:16:03]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 22:16:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 22:51:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 22:51:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2016-12-13 23:53:01]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 23:53:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 00:29:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 00:29:02]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[oshima, 2016-12-21 01:50:26]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 01:50:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 03:02:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 03:02:16]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-12-21 21:19:52]

Patchset #5 (id:100001) has been deleted

[oshima, 2016-12-21 21:20:00]

Patchset #5 (id:120001) has been deleted

[oshima, 2016-12-21 21:20:09]

Patchset #4 (id:80001) has been deleted

[oshima, 2016-12-21 21:21:59]

sadrul, can you review this?

sky@ already lgtm'ed the main change. The difference is that
original test was font configuration dependent, and was failing on bots. I
changed it so that it tests the display rect has max width. thanks.

[oshima, 2016-12-21 21:22:30]

oshima@chromium.org changed reviewers:
+ sadrul@chromium.org

[oshima, 2016-12-21 21:22:30]

sadrul, can you review this?

sky@ already lgtm'ed the main change. The difference is that
original test was font configuration dependent, and was failing on bots. I
changed it so that it tests the display rect has max width. thanks.

[sadrul, 2016-12-22 00:37:43]

lgtm

[oshima, 2016-12-22 02:08:49]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-12-22 02:08:50]

The patchset sent to the CQ was uploaded after l-g-t-m from warx@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2556083002/#ps140001
(title: "update test")

[commit-bot: I haz the power, 2016-12-22 02:09:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 04:14:47]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1482372529954190,
"parent_rev": "ae88af224cc2ae342a38ba46944e9f4c3421627d", "commit_rev":
"a9e1d547924b9d680dc6d5cd54a0b53883b96288"}

[commit-bot: I haz the power, 2016-12-22 04:16:20]

Description was changed from

==========
Don't subtract border from max size for display rect.

The display rect must be consistent with max size,
otherwise the text may not fit.

BUG=664370
TEST=TooltipControllerTest.TestMaxWidth
==========

to

==========
Don't subtract border from max size for display rect.

The display rect must be consistent with max size,
otherwise the text may not fit.

BUG=664370
TEST=TooltipControllerTest.TestMaxWidth

Review-Url: https://codereview.chromium.org/2556083002
==========

[commit-bot: I haz the power, 2016-12-22 04:16:21]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2016-12-22 04:19:38]

Description was changed from

==========
Don't subtract border from max size for display rect.

The display rect must be consistent with max size,
otherwise the text may not fit.

BUG=664370
TEST=TooltipControllerTest.TestMaxWidth

Review-Url: https://codereview.chromium.org/2556083002
==========

to

==========
Don't subtract border from max size for display rect.

The display rect must be consistent with max size,
otherwise the text may not fit.

BUG=664370
TEST=TooltipControllerTest.TestMaxWidth

Committed: https://crrev.com/8658c9c6854e1a550d2adc155cb17dc8ed39e62c
Cr-Commit-Position: refs/heads/master@{#440337}
==========

[commit-bot: I haz the power, 2016-12-22 04:19:39]

Patchset 4 (id:??) landed as
https://crrev.com/8658c9c6854e1a550d2adc155cb17dc8ed39e62c
Cr-Commit-Position: refs/heads/master@{#440337}