third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp - Issue 2556053002: Clarify when DocumentLoader's FrameLoader/FrameLoaderClient accessors can be used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Issue 2556053002: Clarify when DocumentLoader's FrameLoader/FrameLoaderClient accessors can be used (Closed)

Patch Set: Rebase and comment fix Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

index 1791624cfa73dd07961aedeb6c96e9dd771cc6c1..3a952109890fd5840a8a9cee3adaf00e8e186dd6 100644

--- a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

+++ b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

@@ -687,6 +687,8 @@ DocumentLoader* FrameLoaderClientImpl::createDocumentLoader(

const ResourceRequest& request,

const SubstituteData& data,

ClientRedirectPolicy clientRedirectPolicy) {

+ DCHECK(frame);

WebDataSourceImpl* ds =

WebDataSourceImpl::create(frame, request, data, clientRedirectPolicy);

if (m_webFrame->client())