Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Side by Side Diff: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Issue 2556053002: Clarify when DocumentLoader's FrameLoader/FrameLoaderClient accessors can be used (Closed)
Patch Set: Rebase and comment fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2011 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 669 matching lines...) Expand 10 before | Expand all | Expand 10 after
680 if (WebFrameClient* client = m_webFrame->client()) 680 if (WebFrameClient* client = m_webFrame->client())
681 client->didMatchCSS(m_webFrame, WebVector<WebString>(addedSelectors), 681 client->didMatchCSS(m_webFrame, WebVector<WebString>(addedSelectors),
682 WebVector<WebString>(removedSelectors)); 682 WebVector<WebString>(removedSelectors));
683 } 683 }
684 684
685 DocumentLoader* FrameLoaderClientImpl::createDocumentLoader( 685 DocumentLoader* FrameLoaderClientImpl::createDocumentLoader(
686 LocalFrame* frame, 686 LocalFrame* frame,
687 const ResourceRequest& request, 687 const ResourceRequest& request,
688 const SubstituteData& data, 688 const SubstituteData& data,
689 ClientRedirectPolicy clientRedirectPolicy) { 689 ClientRedirectPolicy clientRedirectPolicy) {
690 DCHECK(frame);
691
690 WebDataSourceImpl* ds = 692 WebDataSourceImpl* ds =
691 WebDataSourceImpl::create(frame, request, data, clientRedirectPolicy); 693 WebDataSourceImpl::create(frame, request, data, clientRedirectPolicy);
692 if (m_webFrame->client()) 694 if (m_webFrame->client())
693 m_webFrame->client()->didCreateDataSource(m_webFrame, ds); 695 m_webFrame->client()->didCreateDataSource(m_webFrame, ds);
694 return ds; 696 return ds;
695 } 697 }
696 698
697 String FrameLoaderClientImpl::userAgent() { 699 String FrameLoaderClientImpl::userAgent() {
698 WebString override = 700 WebString override =
699 m_webFrame->client() ? m_webFrame->client()->userAgentOverride() : ""; 701 m_webFrame->client() ? m_webFrame->client()->userAgentOverride() : "";
(...skipping 296 matching lines...) Expand 10 before | Expand all | Expand 10 after
996 WebDevToolsAgentImpl* FrameLoaderClientImpl::devToolsAgent() { 998 WebDevToolsAgentImpl* FrameLoaderClientImpl::devToolsAgent() {
997 return WebLocalFrameImpl::fromFrame(m_webFrame->frame()->localFrameRoot()) 999 return WebLocalFrameImpl::fromFrame(m_webFrame->frame()->localFrameRoot())
998 ->devToolsAgentImpl(); 1000 ->devToolsAgentImpl();
999 } 1001 }
1000 1002
1001 KURL FrameLoaderClientImpl::overrideFlashEmbedWithHTML(const KURL& url) { 1003 KURL FrameLoaderClientImpl::overrideFlashEmbedWithHTML(const KURL& url) {
1002 return m_webFrame->client()->overrideFlashEmbedWithHTML(WebURL(url)); 1004 return m_webFrame->client()->overrideFlashEmbedWithHTML(WebURL(url));
1003 } 1005 }
1004 1006
1005 } // namespace blink 1007 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698