Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2555963005: [SystemWebViewShell] Prevent activity recycling for DIP scale changes (Closed)

Created:
4 years ago by Tima Vaisburd
Modified:
4 years ago
Reviewers:
boliu, timvolodine
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SystemWebViewShell] Prevent activity recycling for DIP scale changes Modified AndroidManifest.xml to include "density" as one of the configuration changes to be processed by activity. With that flag the activity will not be recycled (onDestroy/onCreate) upon the density change, Android will call onCongifurationChanged() instead. BUG=620929 Committed: https://crrev.com/06ad74dc6f599d3fbe163433a030da25a76c6506 Cr-Commit-Position: refs/heads/master@{#439902}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M android_webview/tools/system_webview_shell/apk/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
Tima Vaisburd
PTAL.
4 years ago (2016-12-20 19:43:52 UTC) #3
boliu
lgtm
4 years ago (2016-12-20 22:35:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555963005/20001
4 years ago (2016-12-20 22:49:23 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-20 22:56:47 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-20 22:58:55 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/06ad74dc6f599d3fbe163433a030da25a76c6506
Cr-Commit-Position: refs/heads/master@{#439902}

Powered by Google App Engine
This is Rietveld 408576698