FasterLocationReload: use ReloadMainResource for JS exposed reloads

FasterLocationReload: use ReloadMainResource for JS exposed reloads

Now all reloads triggered by user interfaces are replaced by
ReloadMainResource, but Location.reload() and History.go() still call
the traditional Reload.

This patch changes them to call ReloadMainResource insteads under a
runtime flag. This flag will be wired to a field study flag later.

This is discussed at loading-dev@ in the following thread.
https://groups.google.com/a/chromium.org/d/topic/loading-dev/gD-MPRcfwVA/discussion

BUG=670237
Committed: https://crrev.com/8cd793e6488686201c9099951b7211abfcf5593f
Cr-Commit-Position: refs/heads/master@{#438766}

[Takashi Toyoshima, 2016-12-07 08:18:02]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 08:18:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2016-12-07 08:37:03]

Description was changed from

==========
FasterLocationReload: use ReloadMainResource for JS exposed reloads

Now all reloads triggered by user interfaces are replaced by
ReloadMainResource, but Location.reload() and History.go() still call
the traditional Reload.

This patch changes them to call ReloadMainResource insteads under a
runtime flag. This flag will be wired to a field study flag later.

BUG=670237
==========

to

==========
FasterLocationReload: use ReloadMainResource for JS exposed reloads

Now all reloads triggered by user interfaces are replaced by
ReloadMainResource, but Location.reload() and History.go() still call
the traditional Reload.

This patch changes them to call ReloadMainResource insteads under a
runtime flag. This flag will be wired to a field study flag later.

BUG=670237
==========

[Takashi Toyoshima, 2016-12-07 08:37:03]

toyoshim@chromium.org changed reviewers:
+ tkent@chromium.org

[Takashi Toyoshima, 2016-12-07 08:40:03]

Description was changed from

==========
FasterLocationReload: use ReloadMainResource for JS exposed reloads

Now all reloads triggered by user interfaces are replaced by
ReloadMainResource, but Location.reload() and History.go() still call
the traditional Reload.

This patch changes them to call ReloadMainResource insteads under a
runtime flag. This flag will be wired to a field study flag later.

BUG=670237
==========

to

==========
FasterLocationReload: use ReloadMainResource for JS exposed reloads

Now all reloads triggered by user interfaces are replaced by
ReloadMainResource, but Location.reload() and History.go() still call
the traditional Reload.

This patch changes them to call ReloadMainResource insteads under a
runtime flag. This flag will be wired to a field study flag later.

This is discussed at loading-dev@ in the following thread.
https://groups.google.com/a/chromium.org/d/topic/loading-dev/gD-MPRcfwVA/disc...

BUG=670237
==========

[commit-bot: I haz the power, 2016-12-07 09:37:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 09:37:02]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Takashi Toyoshima, 2016-12-09 06:28:49]

ptal

[tkent, 2016-12-09 06:35:07]

Can you add tests?

Also, please get LGTM from someone in loading team before my approval.

[tkent, 2016-12-09 06:35:30]

> Also, please get LGTM from someone in loading team before my approval.

oops, not lgtm yet.

[Takashi Toyoshima, 2016-12-09 09:58:26]

toyoshim@chromium.org changed reviewers:
+ yhirano@chromium.org

[Takashi Toyoshima, 2016-12-09 09:59:54]

+yhirano from loading team.

yhirano:
I will add a layout test for this as Kent-san suggested.
So, it's fine not starting review now.

[Takashi Toyoshima, 2016-12-13 11:01:10]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[Takashi Toyoshima, 2016-12-13 11:01:28]

yhirano: ptal.
Now this has a layout test.

[commit-bot: I haz the power, 2016-12-13 11:01:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 12:38:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 12:38:03]

Dry run: This issue passed the CQ dry run.

[Takashi Toyoshima, 2016-12-14 05:02:42]

toyoshim@chromium.org changed reviewers:
+ kouhei@chromium.org

[Takashi Toyoshima, 2016-12-14 05:03:28]

+kouhei since yhirano is ooo, can you take a look this if you can?

[kouhei (in TOK), 2016-12-14 10:57:41]

https://codereview.chromium.org/2555963003/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/cache/location-reload.html
(right):

https://codereview.chromium.org/2555963003/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/cache/location-reload.html:36: },
false);
Try addEventListener("msg", e => {...},  {once: true}) instead of
expectedMessage?

https://codereview.chromium.org/2555963003/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/cache/location-reload.html:42:
assert_class_string(testWindow, "Window", "window.open() fails");
s/fails/failed

https://codereview.chromium.org/2555963003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/NavigationScheduler.cpp (right):

https://codereview.chromium.org/2555963003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/NavigationScheduler.cpp:277:
frame->loader().load(request, m_type);
Instead of referring to m_type here, can this also check 
RuntimeEnabledFeatures::fasterLocationReloadEnabled()?

[Takashi Toyoshima, 2016-12-14 12:31:10]

https://codereview.chromium.org/2555963003/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/cache/location-reload.html
(right):

https://codereview.chromium.org/2555963003/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/cache/location-reload.html:36: },
false);
On 2016/12/14 10:57:41, kouhei wrote:
> Try addEventListener("msg", e => {...},  {once: true}) instead of
> expectedMessage?

Done.

https://codereview.chromium.org/2555963003/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/cache/location-reload.html:42:
assert_class_string(testWindow, "Window", "window.open() fails");
On 2016/12/14 10:57:41, kouhei wrote:
> s/fails/failed

Done.

https://codereview.chromium.org/2555963003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/NavigationScheduler.cpp (right):

https://codereview.chromium.org/2555963003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/NavigationScheduler.cpp:277:
frame->loader().load(request, m_type);
On 2016/12/14 10:57:41, kouhei wrote:
> Instead of referring to m_type here, can this also check 
> RuntimeEnabledFeatures::fasterLocationReloadEnabled()?

Done.

[kouhei (in TOK), 2016-12-14 22:52:49]

lgtm

[kouhei (in TOK), 2016-12-14 22:52:54]

The CQ bit was checked by kouhei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 22:53:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-12-14 22:59:43]

lgtm

https://codereview.chromium.org/2555963003/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/http/tests/cache/location-reload.html
(right):

https://codereview.chromium.org/2555963003/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/cache/location-reload.html:2:
<h1>random</h1>
Is this necessary?

[commit-bot: I haz the power, 2016-12-15 02:07:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 02:07:27]

Dry run: This issue passed the CQ dry run.

[Takashi Toyoshima, 2016-12-15 04:45:32]

did minor cleanups for the layout test.

https://codereview.chromium.org/2555963003/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/http/tests/cache/location-reload.html
(right):

https://codereview.chromium.org/2555963003/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/http/tests/cache/location-reload.html:2:
<h1>random</h1>
Oops, this should be moved into resource/location-reload-window.html.

[Takashi Toyoshima, 2016-12-15 04:46:15]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2016-12-15 04:46:16]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/2555963003/#ps120001
(title: "test")

[commit-bot: I haz the power, 2016-12-15 04:46:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 06:25:24]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1481777175799330,
"parent_rev": "d8858c1983985c5c8c9f8d63139dbeda0ba86864", "commit_rev":
"007b0e5a4e7be458e306e551f7f190fd582b16fa"}

[commit-bot: I haz the power, 2016-12-15 06:26:18]

Description was changed from

==========
FasterLocationReload: use ReloadMainResource for JS exposed reloads

Now all reloads triggered by user interfaces are replaced by
ReloadMainResource, but Location.reload() and History.go() still call
the traditional Reload.

This patch changes them to call ReloadMainResource insteads under a
runtime flag. This flag will be wired to a field study flag later.

This is discussed at loading-dev@ in the following thread.
https://groups.google.com/a/chromium.org/d/topic/loading-dev/gD-MPRcfwVA/disc...

BUG=670237
==========

to

==========
FasterLocationReload: use ReloadMainResource for JS exposed reloads

Now all reloads triggered by user interfaces are replaced by
ReloadMainResource, but Location.reload() and History.go() still call
the traditional Reload.

This patch changes them to call ReloadMainResource insteads under a
runtime flag. This flag will be wired to a field study flag later.

This is discussed at loading-dev@ in the following thread.
https://groups.google.com/a/chromium.org/d/topic/loading-dev/gD-MPRcfwVA/disc...

BUG=670237

Review-Url: https://codereview.chromium.org/2555963003
==========

[commit-bot: I haz the power, 2016-12-15 06:26:19]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-12-15 06:28:44]

Description was changed from

==========
FasterLocationReload: use ReloadMainResource for JS exposed reloads

Now all reloads triggered by user interfaces are replaced by
ReloadMainResource, but Location.reload() and History.go() still call
the traditional Reload.

This patch changes them to call ReloadMainResource insteads under a
runtime flag. This flag will be wired to a field study flag later.

This is discussed at loading-dev@ in the following thread.
https://groups.google.com/a/chromium.org/d/topic/loading-dev/gD-MPRcfwVA/disc...

BUG=670237

Review-Url: https://codereview.chromium.org/2555963003
==========

to

==========
FasterLocationReload: use ReloadMainResource for JS exposed reloads

Now all reloads triggered by user interfaces are replaced by
ReloadMainResource, but Location.reload() and History.go() still call
the traditional Reload.

This patch changes them to call ReloadMainResource insteads under a
runtime flag. This flag will be wired to a field study flag later.

This is discussed at loading-dev@ in the following thread.
https://groups.google.com/a/chromium.org/d/topic/loading-dev/gD-MPRcfwVA/disc...

BUG=670237

Committed: https://crrev.com/8cd793e6488686201c9099951b7211abfcf5593f
Cr-Commit-Position: refs/heads/master@{#438766}
==========

[commit-bot: I haz the power, 2016-12-15 06:28:45]

Patchset 7 (id:??) landed as
https://crrev.com/8cd793e6488686201c9099951b7211abfcf5593f
Cr-Commit-Position: refs/heads/master@{#438766}