Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)
Patch Set: Rebase after reopen Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc
index 942d384a5574609ff91c56485dce4b72e65d55db..0c1683259cab194e0e9670b11d7e2f6a3bed89fa 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc
@@ -34,7 +34,8 @@ TEST(NGConstraintSpaceTest, LayoutOpportunitiesNoExclusions) {
NGLogicalSize size;
size.inline_size = LayoutUnit(600);
size.block_size = LayoutUnit(400);
- auto* space = ConstructConstraintSpace(kHorizontalTopBottom, LTR, size);
+ auto* space =
+ ConstructConstraintSpace(kHorizontalTopBottom, TextDirection::Ltr, size);
auto* iterator = space->LayoutOpportunities();
EXPECT_EQ("0,0 600x400", OpportunityToString(iterator->Next()));
EXPECT_EQ("(empty)", OpportunityToString(iterator->Next()));
@@ -45,7 +46,8 @@ TEST(NGConstraintSpaceTest, LayoutOpportunitiesTopRightExclusion) {
size.inline_size = LayoutUnit(600);
size.block_size = LayoutUnit(400);
// Create a space with a 100x100 exclusion in the top right corner.
- auto* space = ConstructConstraintSpace(kHorizontalTopBottom, LTR, size);
+ auto* space =
+ ConstructConstraintSpace(kHorizontalTopBottom, TextDirection::Ltr, size);
NGExclusion exclusion;
exclusion.rect.size = {/* inline_size */ LayoutUnit(100),
/* block_size */ LayoutUnit(100)};
@@ -66,7 +68,8 @@ TEST(NGConstraintSpaceTest, LayoutOpportunitiesTopLeftExclusion) {
size.inline_size = LayoutUnit(600);
size.block_size = LayoutUnit(400);
// Create a space with a 100x100 exclusion in the top left corner.
- auto* space = ConstructConstraintSpace(kHorizontalTopBottom, LTR, size);
+ auto* space =
+ ConstructConstraintSpace(kHorizontalTopBottom, TextDirection::Ltr, size);
NGExclusion exclusion;
exclusion.rect.size = {/* inline_size */ LayoutUnit(100),
/* block_size */ LayoutUnit(100)};
@@ -109,7 +112,8 @@ TEST(NGConstraintSpaceTest, LayoutOpportunitiesTwoInMiddle) {
NGLogicalSize size;
size.inline_size = LayoutUnit(600);
size.block_size = LayoutUnit(400);
- auto* space = ConstructConstraintSpace(kHorizontalTopBottom, LTR, size);
+ auto* space =
+ ConstructConstraintSpace(kHorizontalTopBottom, TextDirection::Ltr, size);
// Add exclusions
NGExclusion exclusion1;
exclusion1.rect.size = {/* inline_size */ LayoutUnit(100),
@@ -156,7 +160,8 @@ TEST(NGConstraintSpaceTest, LayoutOpportunitiesTwoInMiddleWithOriginAndLeader) {
NGLogicalSize size;
size.inline_size = LayoutUnit(600);
size.block_size = LayoutUnit(400);
- auto* space = ConstructConstraintSpace(kHorizontalTopBottom, LTR, size);
+ auto* space =
+ ConstructConstraintSpace(kHorizontalTopBottom, TextDirection::Ltr, size);
// Add exclusions
NGExclusion exclusion1;
exclusion1.rect.size = {/* inline_size */ LayoutUnit(100),
@@ -204,7 +209,8 @@ TEST(NGConstraintSpaceTest, LayoutOpportunitiesWithOutOfBoundsExclusions) {
NGLogicalSize size;
size.inline_size = LayoutUnit(600);
size.block_size = LayoutUnit(100);
- auto* space = ConstructConstraintSpace(kHorizontalTopBottom, LTR, size);
+ auto* space =
+ ConstructConstraintSpace(kHorizontalTopBottom, TextDirection::Ltr, size);
NGExclusion exclusion;
exclusion.rect.size = {/* inline_size */ LayoutUnit(100),
/* block_size */ LayoutUnit(100)};

Powered by Google App Engine
This is Rietveld 408576698