third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Rebase after reopen Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc

index 921f53f20c734446d53108e179f1d14b750b8850..71e50cae09e8906c5148529a7b131db969cd3294 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc

@@ -18,7 +18,7 @@ NGConstraintSpaceBuilder::NGConstraintSpaceBuilder(

is_block_direction_triggers_scrollbar_(false),

fragmentation_type_(kFragmentNone),

is_new_fc_(parent_space->IsNewFormattingContext()),

- text_direction_(parent_space->Direction()),

+ text_direction_(static_cast<unsigned>(parent_space->Direction())),

exclusions_(parent_space->Exclusions()) {}

NGConstraintSpaceBuilder::NGConstraintSpaceBuilder(NGWritingMode writing_mode)

@@ -30,7 +30,7 @@ NGConstraintSpaceBuilder::NGConstraintSpaceBuilder(NGWritingMode writing_mode)

is_block_direction_triggers_scrollbar_(false),

fragmentation_type_(kFragmentNone),

is_new_fc_(false),

- text_direction_(TextDirection::LTR),

+ text_direction_(static_cast<unsigned>(TextDirection::Ltr)),

exclusions_(new NGExclusions()) {}

NGConstraintSpaceBuilder& NGConstraintSpaceBuilder::SetAvailableSize(

@@ -47,7 +47,7 @@ NGConstraintSpaceBuilder& NGConstraintSpaceBuilder::SetPercentageResolutionSize(

NGConstraintSpaceBuilder& NGConstraintSpaceBuilder::SetTextDirection(

TextDirection text_direction) {

- text_direction_ = text_direction;

+ text_direction_ = static_cast<unsigned>(text_direction);

return *this;

}