third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Rebase after reopen Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp b/third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp

index f7e5795796cbba72715d7e51f53be53b76266da6..1ff6278ae79eebb7032824063de1591ec8ad66a4 100644

--- a/third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp

@@ -116,7 +116,8 @@ PassRefPtr<ComputedStyle> HTMLImageFallbackHelper::customStyleForAltText(

// image for the element's writing direction.

brokenImage->setInlineStyleProperty(

CSSPropertyFloat,

- AtomicString(newStyle->direction() == LTR ? "left" : "right"));

+ AtomicString(newStyle->direction() == TextDirection::Ltr ? "left"

+ : "right"));

// This is an <img> with no attributes, so don't display anything.

if (noImageSourceSpecified(element) &&