Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)
Patch Set: Rebase after reopen Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp b/third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp
index 96678e6fa002f14838499dd618e532805446206b..e0509253f1e58064e5203596cb9959ddc3d7ee2c 100644
--- a/third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLFormControlElementTest.cpp
@@ -52,35 +52,35 @@ TEST_F(HTMLFormControlElementTest, customValidationMessageTextDirection) {
String message = input->validationMessage().stripWhiteSpace();
String subMessage = input->validationSubMessage().stripWhiteSpace();
- TextDirection messageDir = RTL;
- TextDirection subMessageDir = LTR;
+ TextDirection messageDir = TextDirection::Rtl;
+ TextDirection subMessageDir = TextDirection::Ltr;
input->findCustomValidationMessageTextDirection(message, messageDir,
subMessage, subMessageDir);
- EXPECT_EQ(RTL, messageDir);
- EXPECT_EQ(LTR, subMessageDir);
+ EXPECT_EQ(TextDirection::Rtl, messageDir);
+ EXPECT_EQ(TextDirection::Ltr, subMessageDir);
- input->layoutObject()->mutableStyleRef().setDirection(RTL);
+ input->layoutObject()->mutableStyleRef().setDirection(TextDirection::Rtl);
input->findCustomValidationMessageTextDirection(message, messageDir,
subMessage, subMessageDir);
- EXPECT_EQ(RTL, messageDir);
- EXPECT_EQ(LTR, subMessageDir);
+ EXPECT_EQ(TextDirection::Rtl, messageDir);
+ EXPECT_EQ(TextDirection::Ltr, subMessageDir);
input->setCustomValidity(String::fromUTF8("Main message."));
message = input->validationMessage().stripWhiteSpace();
subMessage = input->validationSubMessage().stripWhiteSpace();
input->findCustomValidationMessageTextDirection(message, messageDir,
subMessage, subMessageDir);
- EXPECT_EQ(LTR, messageDir);
- EXPECT_EQ(LTR, subMessageDir);
+ EXPECT_EQ(TextDirection::Ltr, messageDir);
+ EXPECT_EQ(TextDirection::Ltr, subMessageDir);
input->setCustomValidity(String());
message = input->validationMessage().stripWhiteSpace();
subMessage = input->validationSubMessage().stripWhiteSpace();
input->findCustomValidationMessageTextDirection(message, messageDir,
subMessage, subMessageDir);
- EXPECT_EQ(LTR, messageDir);
- EXPECT_EQ(RTL, subMessageDir);
+ EXPECT_EQ(TextDirection::Ltr, messageDir);
+ EXPECT_EQ(TextDirection::Rtl, subMessageDir);
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698