third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Rebase after reopen Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index 92b46e9a1c3850ba0c0b3fbf8bcaefc9d77e9724..2b085b9027e6b1d072848d10ed4f460ecd54619b 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -1959,9 +1959,11 @@ bool FrameView::computeCompositedSelection(LocalFrame& frame,

}

selection.start.isTextDirectionRTL |=

- primaryDirectionOf(*visibleSelection.start().anchorNode()) == RTL;

+ primaryDirectionOf(*visibleSelection.start().anchorNode()) ==

+ TextDirection::Rtl;

selection.end.isTextDirectionRTL |=

- primaryDirectionOf(*visibleSelection.end().anchorNode()) == RTL;

+ primaryDirectionOf(*visibleSelection.end().anchorNode()) ==

+ TextDirection::Rtl;

return true;

}