Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)
Patch Set: Rebase after reopen Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1941 matching lines...) Expand 10 before | Expand all | Expand 10 after
1952 selection.type = visibleSelection.getSelectionType(); 1952 selection.type = visibleSelection.getSelectionType();
1953 selection.isEditable = visibleSelection.isContentEditable(); 1953 selection.isEditable = visibleSelection.isContentEditable();
1954 if (selection.isEditable) { 1954 if (selection.isEditable) {
1955 if (TextControlElement* enclosingTextControlElement = 1955 if (TextControlElement* enclosingTextControlElement =
1956 enclosingTextControl(visibleSelection.rootEditableElement())) { 1956 enclosingTextControl(visibleSelection.rootEditableElement())) {
1957 selection.isEmptyTextControl = 1957 selection.isEmptyTextControl =
1958 enclosingTextControlElement->value().isEmpty(); 1958 enclosingTextControlElement->value().isEmpty();
1959 } 1959 }
1960 } 1960 }
1961 selection.start.isTextDirectionRTL |= 1961 selection.start.isTextDirectionRTL |=
1962 primaryDirectionOf(*visibleSelection.start().anchorNode()) == RTL; 1962 primaryDirectionOf(*visibleSelection.start().anchorNode()) ==
1963 TextDirection::Rtl;
1963 selection.end.isTextDirectionRTL |= 1964 selection.end.isTextDirectionRTL |=
1964 primaryDirectionOf(*visibleSelection.end().anchorNode()) == RTL; 1965 primaryDirectionOf(*visibleSelection.end().anchorNode()) ==
1966 TextDirection::Rtl;
1965 1967
1966 return true; 1968 return true;
1967 } 1969 }
1968 1970
1969 void FrameView::updateCompositedSelectionIfNeeded() { 1971 void FrameView::updateCompositedSelectionIfNeeded() {
1970 if (!RuntimeEnabledFeatures::compositedSelectionUpdateEnabled()) 1972 if (!RuntimeEnabledFeatures::compositedSelectionUpdateEnabled())
1971 return; 1973 return;
1972 1974
1973 TRACE_EVENT0("blink", "FrameView::updateCompositedSelectionIfNeeded"); 1975 TRACE_EVENT0("blink", "FrameView::updateCompositedSelectionIfNeeded");
1974 1976
(...skipping 2870 matching lines...) Expand 10 before | Expand all | Expand 10 after
4845 return result; 4847 return result;
4846 } 4848 }
4847 4849
4848 String result(MainThreadScrollingReason::mainThreadScrollingReasonsAsText( 4850 String result(MainThreadScrollingReason::mainThreadScrollingReasonsAsText(
4849 m_mainThreadScrollingReasons) 4851 m_mainThreadScrollingReasons)
4850 .c_str()); 4852 .c_str());
4851 return result; 4853 return result;
4852 } 4854 }
4853 4855
4854 } // namespace blink 4856 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleUnits.cpp ('k') | third_party/WebKit/Source/core/html/HTMLElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698