third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp - Issue 2555923002: Changed TextDirection to an enum class and renamed its members

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)

Patch Set: Rebase after reopen Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp b/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

index 0545234993a427027970d1f464c072dc1c1e3855..1e90530d5cf346692d96f99905ec773cc2698f9b 100644

--- a/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

+++ b/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

@@ -21,8 +21,9 @@ TEST_F(EditingUtilitiesTest, directionOfEnclosingBlock) {

setShadowContent(shadowContent, "host");

Node* one = document().getElementById("one");

- EXPECT_EQ(LTR, directionOfEnclosingBlock(Position(one, 0)));

- EXPECT_EQ(RTL, directionOfEnclosingBlock(PositionInFlatTree(one, 0)));

+ EXPECT_EQ(TextDirection::Ltr, directionOfEnclosingBlock(Position(one, 0)));

+ EXPECT_EQ(TextDirection::Rtl,

+ directionOfEnclosingBlock(PositionInFlatTree(one, 0)));

}

TEST_F(EditingUtilitiesTest, firstEditablePositionAfterPositionInRoot) {