Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilities.cpp

Issue 2555923002: Changed TextDirection to an enum class and renamed its members (Closed)
Patch Set: Rebase after reopen Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/EditingUtilities.cpp
diff --git a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
index bfd1a9634913f1e8b65a58c433aa38f45b9bc062..3d52f33c4ce7ab1e423ee88a80188faa17a9049f 100644
--- a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
+++ b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
@@ -956,9 +956,9 @@ TextDirection directionOfEnclosingBlockAlgorithm(
position.computeContainerNode()),
CannotCrossEditingBoundary);
if (!enclosingBlockElement)
- return LTR;
+ return TextDirection::Ltr;
LayoutObject* layoutObject = enclosingBlockElement->layoutObject();
- return layoutObject ? layoutObject->style()->direction() : LTR;
+ return layoutObject ? layoutObject->style()->direction() : TextDirection::Ltr;
}
TextDirection directionOfEnclosingBlock(const Position& position) {
@@ -971,7 +971,7 @@ TextDirection directionOfEnclosingBlock(const PositionInFlatTree& position) {
}
TextDirection primaryDirectionOf(const Node& node) {
- TextDirection primaryDirection = LTR;
+ TextDirection primaryDirection = TextDirection::Ltr;
for (const LayoutObject* r = node.layoutObject(); r; r = r->parent()) {
if (r->isLayoutBlockFlow()) {
primaryDirection = r->style()->direction();

Powered by Google App Engine
This is Rietveld 408576698