Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: remoting/client/gl_renderer.h

Issue 2555803002: Adding the iOS app and integration example with GlRenderer. (Closed)
Patch Set: Adjusting how gl_renderer draws layers and added a demo app for CRD iOS. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/gl_renderer.h
diff --git a/remoting/client/gl_renderer.h b/remoting/client/gl_renderer.h
index 832bd636667a43a2f8915bf45feed3ed8782b762..17b7b3bdb931f193b3d62d221d117bd531ef0fd5 100644
--- a/remoting/client/gl_renderer.h
+++ b/remoting/client/gl_renderer.h
@@ -6,6 +6,7 @@
#define REMOTING_CLIENT_GL_RENDERER_H_
#include <queue>
+#include <vector>
#include "base/callback.h"
#include "base/macros.h"
@@ -91,6 +92,8 @@ class GlRenderer {
// Called when the surface is destroyed.
void OnSurfaceDestroyed();
+ void AddDrawable(GlDrawable* drawable);
Yuwei 2016/12/19 23:26:09 Could we just make the class own the drawable? Hol
Yuwei 2016/12/19 23:54:19 I meant something like ShouldDrawDemoScreen(boolea
+
// Returns the weak pointer to be used on the display thread.
base::WeakPtr<GlRenderer> GetWeakPtr();
@@ -125,6 +128,8 @@ class GlRenderer {
GlCursorFeedback cursor_feedback_;
GlDesktop desktop_;
+ std::vector<GlDrawable*> drawables;
joedow 2016/12/19 23:56:26 Does order of the drawing matter? Maybe add a com
joedow 2016/12/19 23:56:26 Is a raw* the right thing? Can ownership be trans
joedow 2016/12/19 23:56:26 s/drawables/drawables_
+
base::ThreadChecker thread_checker_;
base::WeakPtr<GlRenderer> weak_ptr_;
base::WeakPtrFactory<GlRenderer> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698