Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2555743008:
[Presentation API] set presentation_receiver flag in offscreen tab (Closed)
Description[Presentation API] set presentation_receiver flag in offscreen tab
crbug.com/647296 exposes settings to control when presentation.receiver should be exposed. Set presentation_receiver flag to true and expose presentation.receiver if offscreen tab is started by presentation API.
BUG=647296
Committed: https://crrev.com/f715bf8834b42c807bdcad10d18c75e503ed9a78
Cr-Commit-Position: refs/heads/master@{#437647}
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
zhaobin@chromium.org changed reviewers: + imcheng@chromium.org, mfoltz@chromium.org, miu@chromium.org, mlamouri@chromium.org
lgtm, but please set BUG=647296 in the change description before committing.
lgtm with miu's comments addressed
Description was changed from ========== [Presentation API] set presentation_receiver flag in offscreen tab crbug.com/647296 exposes settings to control when presentation.receiver should be exposed. Set presentation_receiver flag to true and expose presentation.receiver if offscreen tab is started by presentation API. BUG= ========== to ========== [Presentation API] set presentation_receiver flag in offscreen tab crbug.com/647296 exposes settings to control when presentation.receiver should be exposed. Set presentation_receiver flag to true and expose presentation.receiver if offscreen tab is started by presentation API. BUG=647296 ==========
lgtm
lgtm
The CQ bit was checked by zhaobin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by zhaobin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481314602982590, "parent_rev":
"3f14c08414d5c1dfd6ca4447323060ccf74ba175", "commit_rev":
"f6dfcf4cd687325937314f0b3f003e540fe4d0a8"}
Message was sent while issue was closed.
Description was changed from ========== [Presentation API] set presentation_receiver flag in offscreen tab crbug.com/647296 exposes settings to control when presentation.receiver should be exposed. Set presentation_receiver flag to true and expose presentation.receiver if offscreen tab is started by presentation API. BUG=647296 ========== to ========== [Presentation API] set presentation_receiver flag in offscreen tab crbug.com/647296 exposes settings to control when presentation.receiver should be exposed. Set presentation_receiver flag to true and expose presentation.receiver if offscreen tab is started by presentation API. BUG=647296 Review-Url: https://codereview.chromium.org/2555743008 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Presentation API] set presentation_receiver flag in offscreen tab crbug.com/647296 exposes settings to control when presentation.receiver should be exposed. Set presentation_receiver flag to true and expose presentation.receiver if offscreen tab is started by presentation API. BUG=647296 Review-Url: https://codereview.chromium.org/2555743008 ========== to ========== [Presentation API] set presentation_receiver flag in offscreen tab crbug.com/647296 exposes settings to control when presentation.receiver should be exposed. Set presentation_receiver flag to true and expose presentation.receiver if offscreen tab is started by presentation API. BUG=647296 Committed: https://crrev.com/f715bf8834b42c807bdcad10d18c75e503ed9a78 Cr-Commit-Position: refs/heads/master@{#437647} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f715bf8834b42c807bdcad10d18c75e503ed9a78 Cr-Commit-Position: refs/heads/master@{#437647} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
