Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2555743007: [Merge-M56] arc: Make sure PlayStore logo image loaded for Arc OptIn OOBE page. (Closed)

Created:
4 years ago by khmel
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Merge-M56] arc: Make sure PlayStore logo image loaded for Arc OptIn OOBE page. From my investigation, there is the case when Chromebook is loaded first time. OOBE UI initializedd on early step and internet connection is not guaranteed at this moment and this may fail image loading. Fix is to reload image before page is actually shown to user. BUG=670750 TEST=Manually on device. Restart/Powerwash - in all cases image is loaded. TBR=xiyuan@chromium.org NOTRY=true NOPRESUBMIT=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2560683002 Cr-Commit-Position: refs/heads/master@{#437040} (cherry picked from commit 3408557009dd278f7272ee07b06704f788509b00)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555743007/1
4 years ago (2016-12-08 19:08:22 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-08 19:11:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698