Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1576)

Issue 2560683002: arc: Make sure PlayStore logo image loaded for Arc OptIn OOBE page. (Closed)

Created:
4 years ago by khmel
Modified:
4 years ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Make sure PlayStore logo image loaded for Arc OptIn OOBE page. From my investigation, there is the case when Chromebook is loaded first time. OOBE UI initializedd on early step and internet connection is not guaranteed at this moment and this may fail image loading. Fix is to reload image before page is actually shown to user. BUG=670750 TEST=Manually on device. Restart/Powerwash - in all cases image is loaded. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/3408557009dd278f7272ee07b06704f788509b00 Cr-Commit-Position: refs/heads/master@{#437040}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
khmel
Hi Xiyuan, PTAL
4 years ago (2016-12-07 01:05:17 UTC) #2
khmel
Hi Xiyuan, PTAL
4 years ago (2016-12-07 16:14:34 UTC) #4
xiyuan
lgtm Yep, we should not access remote resources during oobe page loading since Internet access ...
4 years ago (2016-12-07 18:23:05 UTC) #5
khmel
Thanks for confirmation! :)
4 years ago (2016-12-07 18:23:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560683002/1
4 years ago (2016-12-07 18:24:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 19:58:36 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-07 20:01:21 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3408557009dd278f7272ee07b06704f788509b00
Cr-Commit-Position: refs/heads/master@{#437040}

Powered by Google App Engine
This is Rietveld 408576698