Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1899)

Unified Diff: cc/tiles/tile_manager.h

Issue 2555743004: Delay activation/draw on GPU tile work completion (Closed)
Patch Set: comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/tiles/tile_manager.h
diff --git a/cc/tiles/tile_manager.h b/cc/tiles/tile_manager.h
index 1136708ebde1b4d5a1cfc7c145d4669391db74c0..2ca60c6cc1e33ed16811fe77de9803cf16e9e702 100644
--- a/cc/tiles/tile_manager.h
+++ b/cc/tiles/tile_manager.h
@@ -148,10 +148,11 @@ class CC_EXPORT TileManager {
void InitializeTilesWithResourcesForTesting(const std::vector<Tile*>& tiles) {
for (size_t i = 0; i < tiles.size(); ++i) {
TileDrawInfo& draw_info = tiles[i]->draw_info();
- draw_info.resource_ = resource_pool_->AcquireResource(
+ draw_info.set_resource(resource_pool_->AcquireResource(
tiles[i]->desired_texture_size(),
raster_buffer_provider_->GetResourceFormat(false),
- client_->GetTileColorSpace());
+ client_->GetTileColorSpace()));
+ draw_info.set_resource_ready_for_draw();
}
}
@@ -303,6 +304,8 @@ class CC_EXPORT TileManager {
bool UsePartialRaster() const;
+ void CheckPendingReadyToDrawTiles(bool issue_signals);
+
TileManagerClient* client_;
base::SequencedTaskRunner* task_runner_;
ResourcePool* resource_pool_;
@@ -340,10 +343,23 @@ class CC_EXPORT TileManager {
uint64_t prepare_tiles_count_;
uint64_t next_tile_id_;
+ std::vector<Tile*> pending_ready_for_draw_tiles_;
+ uint64_t pending_required_for_activation_callback_id_ = 0;
+ uint64_t pending_required_for_draw_callback_id_ = 0;
+ // If true, we should re-compute tile requirements in
+ // CheckPendingReadyToDrawTiles.
+ bool pending_tile_requirements_dirty_ = false;
+
std::unordered_map<Tile::Id, std::vector<DrawImage>> scheduled_draw_images_;
std::vector<scoped_refptr<TileTask>> locked_image_tasks_;
+ // We need two WeakPtrFactory objects as the invalidation pattern of each is
+ // different. The |task_set_finished_weak_ptr_factory_| is invalidated any
+ // time new tasks are scheduled, preventing a race when the callback has
+ // been scheduled but not yet executed.
base::WeakPtrFactory<TileManager> task_set_finished_weak_ptr_factory_;
+ // The |ready_to_draw_callback_weak_ptr_factory_| is never invalidated.
+ base::WeakPtrFactory<TileManager> ready_to_draw_callback_weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(TileManager);
};
« no previous file with comments | « cc/tiles/tile_draw_info.cc ('k') | cc/tiles/tile_manager.cc » ('j') | cc/tiles/tile_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698