Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2555693006: MD Downloads: fix some a11y issues (Closed)

Created:
4 years ago by Dan Beam
Modified:
4 years ago
Reviewers:
calamity
CC:
chromium-reviews, asanka, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: fix some a11y issues * up contrast to 4.5:1 for small text * fix some aria roles * update header colors (and make settings match while I'm at it) R=calamity@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/382d94ea2fa27cbd874b679a955f63ca804279df Cr-Commit-Position: refs/heads/master@{#437603}

Patch Set 1 #

Total comments: 2

Patch Set 2 : more nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M chrome/browser/resources/md_downloads/item.html View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_downloads/manager.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_section.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (15 generated)
Dan Beam
4 years ago (2016-12-08 04:30:23 UTC) #2
calamity
lgtm w/ question. https://codereview.chromium.org/2555693006/diff/1/chrome/browser/resources/md_downloads/item.html File chrome/browser/resources/md_downloads/item.html (right): https://codereview.chromium.org/2555693006/diff/1/chrome/browser/resources/md_downloads/item.html#newcode33 chrome/browser/resources/md_downloads/item.html:33: color: rgb(103, 112, 115); Is this ...
4 years ago (2016-12-09 01:31:42 UTC) #7
Dan Beam
https://codereview.chromium.org/2555693006/diff/1/chrome/browser/resources/md_downloads/item.html File chrome/browser/resources/md_downloads/item.html (right): https://codereview.chromium.org/2555693006/diff/1/chrome/browser/resources/md_downloads/item.html#newcode33 chrome/browser/resources/md_downloads/item.html:33: color: rgb(103, 112, 115); On 2016/12/09 01:31:42, calamity wrote: ...
4 years ago (2016-12-09 02:03:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555693006/20001
4 years ago (2016-12-09 18:54:35 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-09 19:12:13 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-12 14:36:44 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/382d94ea2fa27cbd874b679a955f63ca804279df
Cr-Commit-Position: refs/heads/master@{#437603}

Powered by Google App Engine
This is Rietveld 408576698