Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2324)

Unified Diff: chrome/browser/ui/views/frame/browser_view_layout.cc

Issue 2555623002: Last round of cleaning up MD layout constants. (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view_layout.cc
diff --git a/chrome/browser/ui/views/frame/browser_view_layout.cc b/chrome/browser/ui/views/frame/browser_view_layout.cc
index 18c70c1a859b17c7e808fae8d708dae13517a9b3..5843faf937c07e7c2c0977999e0b247e3e75d1c4 100644
--- a/chrome/browser/ui/views/frame/browser_view_layout.cc
+++ b/chrome/browser/ui/views/frame/browser_view_layout.cc
@@ -12,7 +12,6 @@
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/find_bar/find_bar.h"
#include "chrome/browser/ui/find_bar/find_bar_controller.h"
-#include "chrome/browser/ui/layout_constants.h"
#include "chrome/browser/ui/search/search_model.h"
#include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h"
#include "chrome/browser/ui/views/download/download_shelf_view.h"
@@ -224,8 +223,8 @@ gfx::Rect BrowserViewLayout::GetFindBarBoundingBox() const {
// Overlap the find bar atop |top_container_|.
// The find bar should look connected to the top container when material
// design is not enabled.
- find_bar_y = top_container_bounds.bottom() -
- GetLayoutConstant(FIND_BAR_TOOLBAR_OVERLAP);
+ const int kOverlapDip = 6;
Peter Kasting 2016/12/08 20:57:49 Nit: Dip suffix optional (I don't mind it, but mos
Evan Stade 2016/12/13 01:31:17 I guess I thought "kOverlap" was insufficiently de
+ find_bar_y = top_container_bounds.bottom() - kOverlapDip;
}
// Grow the height of |bounding_box| by the height of any elements between

Powered by Google App Engine
This is Rietveld 408576698