Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 255553004: Split [StrictTypeChecking] into [TypeChecking=Interface|Nullable|String] (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove redundant flag Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_interface.py ('k') | Source/bindings/templates/attributes.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_methods.py
diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py
index 94f22f33814e7d2d9871f4d72c35767929293390..b45e7330b185339bfc6700e6a8b0eb9abbcbd085 100644
--- a/Source/bindings/scripts/v8_methods.py
+++ b/Source/bindings/scripts/v8_methods.py
@@ -120,9 +120,6 @@ def generate_method(interface, method):
'is_raises_exception': is_raises_exception,
'is_read_only': 'ReadOnly' in extended_attributes,
'is_static': is_static,
- 'is_strict_type_checking':
- 'StrictTypeChecking' in extended_attributes or
- 'StrictTypeChecking' in interface.extended_attributes,
'is_variadic': arguments and arguments[-1].is_variadic,
'measure_as': v8_utilities.measure_as(method), # [MeasureAs]
'name': name,
@@ -157,6 +154,15 @@ def generate_argument(interface, method, argument, index):
'has_event_listener_argument': any(
argument_so_far for argument_so_far in method.arguments[:index]
if argument_so_far.idl_type.name == 'EventListener'),
+ 'has_type_checking_interface':
+ (has_extended_attribute_value(interface, 'TypeChecking', 'Interface') or
+ has_extended_attribute_value(method, 'TypeChecking', 'Interface') or
+ has_extended_attribute_value(argument, 'TypeChecking', 'Interface')) and
+ idl_type.is_wrapper_type,
+ 'has_type_checking_string':
+ (has_extended_attribute_value(interface, 'TypeChecking', 'String') or
+ has_extended_attribute_value(method, 'TypeChecking', 'String') or
+ has_extended_attribute_value(argument, 'TypeChecking', 'String')),
# Dictionary is special-cased, but arrays and sequences shouldn't be
'idl_type': not idl_type.array_or_sequence_type and idl_type.base_type,
'idl_type_object': idl_type,
@@ -165,7 +171,6 @@ def generate_argument(interface, method, argument, index):
'is_callback_interface': idl_type.is_callback_interface,
'is_nullable': idl_type.is_nullable,
'is_optional': argument.is_optional,
- 'is_strict_type_checking': 'StrictTypeChecking' in extended_attributes,
'is_variadic_wrapper_type': is_variadic_wrapper_type,
'vector_type': v8_types.cpp_ptr_type('Vector', 'HeapVector', idl_type.gc_type),
'is_wrapper_type': idl_type.is_wrapper_type,
« no previous file with comments | « Source/bindings/scripts/v8_interface.py ('k') | Source/bindings/templates/attributes.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698