Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 255553004: Split [StrictTypeChecking] into [TypeChecking=Interface|Nullable|String] (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove redundant flag Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/bindings/scripts/v8_methods.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_interface.py
diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py
index d6ca91d42e6fa312d268b03bfb255b13fd1c2ba2..3b56e1d4065090e24c43cb855460310ee5af11bd 100644
--- a/Source/bindings/scripts/v8_interface.py
+++ b/Source/bindings/scripts/v8_interface.py
@@ -418,7 +418,7 @@ def overload_check_argument(index, argument):
cpp_value = 'info[%s]' % index
idl_type = argument['idl_type_object']
# FIXME: proper type checking, sharing code with attributes and methods
- if idl_type.name == 'String' and argument['is_strict_type_checking']:
+ if idl_type.name == 'String' and argument['has_type_checking_string']:
return ' || '.join(['isUndefinedOrNull(%s)' % cpp_value,
'%s->IsString()' % cpp_value,
'%s->IsObject()' % cpp_value])
@@ -500,12 +500,12 @@ def constructor_argument(interface, constructor, argument, index):
'cpp_value':
v8_methods.cpp_value(interface, constructor, index),
'has_default': 'Default' in argument.extended_attributes,
+ 'has_type_checking_string': False, # Required for overload resolution
# Dictionary is special-cased, but arrays and sequences shouldn't be
'idl_type': not idl_type.array_or_sequence_type and idl_type.base_type,
'idl_type_object': idl_type,
'index': index,
'is_optional': argument.is_optional,
- 'is_strict_type_checking': False, # Required for overload resolution
'name': argument.name,
'v8_value_to_local_cpp_value':
v8_methods.v8_value_to_local_cpp_value(argument, index),
@@ -612,8 +612,8 @@ def property_setter(setter):
extended_attributes = setter.extended_attributes
is_raises_exception = 'RaisesException' in extended_attributes
return {
- 'has_strict_type_checking':
- 'StrictTypeChecking' in extended_attributes and
+ 'has_type_checking_interface':
+ has_extended_attribute_value(setter, 'TypeChecking', 'Interface') and
idl_type.is_wrapper_type,
'idl_type': idl_type.base_type,
'is_custom': 'Custom' in extended_attributes,
« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/bindings/scripts/v8_methods.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698