Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2555513002: Don't require GL_ARB_gpu_shader5 in order to support ES 3.0. (Closed)

Created:
4 years ago by Ken Russell (switch to Gerrit)
Modified:
4 years ago
CC:
chromium-reviews, Kai Ninomiya
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't require GL_ARB_gpu_shader5 in order to support ES 3.0. ES 3.0 and ESSL 3.00 expressly forbid dynamic indexing of sampler arrays, so don't impose a stricter requirement on the desktop OpenGL drivers than needed. BUG=671280 Committed: https://crrev.com/2bd1f057280fea281637bb63265225303c35850a Cr-Commit-Position: refs/heads/master@{#436392}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M ui/gl/gl_version_info.cc View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Ken Russell (switch to Gerrit)
PTAL
4 years ago (2016-12-05 19:01:47 UTC) #2
Corentin Wallez
lgtm
4 years ago (2016-12-05 19:05:51 UTC) #3
Zhenyao Mo
On 2016/12/05 19:05:51, Corentin Wallez wrote: > lgtm lgtm also
4 years ago (2016-12-05 19:08:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555513002/1
4 years ago (2016-12-05 19:09:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 20:41:50 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-05 20:44:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2bd1f057280fea281637bb63265225303c35850a
Cr-Commit-Position: refs/heads/master@{#436392}

Powered by Google App Engine
This is Rietveld 408576698