Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: ui/gl/gl_version_info.cc

Issue 2555513002: Don't require GL_ARB_gpu_shader5 in order to support ES 3.0. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_version_info.cc
diff --git a/ui/gl/gl_version_info.cc b/ui/gl/gl_version_info.cc
index bce82642e1d015ee0e878361282bf49fadc50025..8561419883366ff7c493156bef48eb7629c3ac33 100644
--- a/ui/gl/gl_version_info.cc
+++ b/ui/gl/gl_version_info.cc
@@ -90,16 +90,19 @@ bool GLVersionInfo::IsES3Capable(
bool has_transform_feedback =
(IsAtLeastGL(4, 0) || has_extension("GL_ARB_transform_feedback2"));
- bool has_sampler_indexing =
- (IsAtLeastGL(4, 0) || has_extension("GL_ARB_gpu_shader5"));
+
+ // This code used to require the GL_ARB_gpu_shader5 extension in order to
+ // have support for dynamic indexing of sampler arrays, which was
+ // optionally supported in ESSL 1.00. However, since this is expressly
+ // forbidden in ESSL 3.00, and some desktop drivers (specifically
+ // Mesa/Gallium on AMD GPUs) don't support it, we no longer require it.
+
// tex storage is available in core spec since GL 4.2.
bool has_tex_storage = has_extension("GL_ARB_texture_storage");
// TODO(cwallez) check for texture related extensions. See crbug.com/623577
- return (has_transform_feedback &&
- has_sampler_indexing &&
- has_tex_storage);
+ return (has_transform_feedback && has_tex_storage);
}
void GLVersionInfo::ParseVersionString(const char* version_str,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698