Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2555493004: Merge 2924: Fix break-all/word-break are applied to inline elements (Closed)

Created:
4 years ago by kojii
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Merge 2924: Fix break-all/word-break are applied to inline elements This patch improves when properties that can break lines in the middle of a word (word-break: break-all and break-word) are applied to inline elements. When no characters can fit but there is a break opportunity in previous runs, the line should break at the opportunity. Also this fix revealed that we have tests of element boundaries relying on parent's style, and they pass only under certain conditions. This was fixed to refer to the parent's style, as recently clarified in CSS Text[1]. [1] https://github.com/w3c/csswg-drafts/issues/189 BUG=668399 Review-Url: https://codereview.chromium.org/2532393006 Cr-Commit-Position: refs/heads/master@{#435899} (cherry picked from commit f2ba82966d78cccb307a6046606a616e27c1f0df) Committed: https://chromium.googlesource.com/chromium/src/+/58e8ebffee4354ed11d2308a6dca6ea7cca6ace3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -12 lines) Patch
A third_party/WebKit/LayoutTests/fast/css3-text/css3-word-break/word-break-break-all-in-span.html View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css3-text/css3-word-break/word-break-break-all-in-span-expected.html View 1 chunk +34 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 4 chunks +42 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kojii
4 years ago (2016-12-06 12:47:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58e8ebffee4354ed11d2308a6dca6ea7cca6ace3.

Powered by Google App Engine
This is Rietveld 408576698