Fix break-all/word-break are applied to inline elements

Fix break-all/word-break are applied to inline elements

This patch improves when properties that can break lines in the middle
of a word (word-break: break-all and break-word) are applied to inline
elements.

When no characters can fit but there is a break opportunity in previous
runs, the line should break at the opportunity.

Also this fix revealed that we have tests of element boundaries relying
on parent's style, and they pass only under certain conditions. This
was fixed to refer to the parent's style, as recently clarified in CSS
Text[1].

[1] https://github.com/w3c/csswg-drafts/issues/189

BUG=668399
Committed: https://crrev.com/f2ba82966d78cccb307a6046606a616e27c1f0df
Cr-Commit-Position: refs/heads/master@{#435899}

[kojii, 2016-12-01 14:53:35]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 14:53:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-12-01 14:58:26]

Description was changed from

==========
break-all

BUG=
==========

to

==========
Fix break-all/word-break when applied to inline elements

When mid-word break properties (word-break: break-all and word-wrap:
break-word) are applied to inline elements, and there are no characters
that can fit in the line, the line breaker should break at the last
break opportunity in the last run.

This patch fixes BreakingContext::rewindToMidWordBreak() to take such
case into account.

BUG=668399
==========

[commit-bot: I haz the power, 2016-12-01 15:53:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 15:53:39]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kojii, 2016-12-01 17:50:05]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 17:50:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 19:28:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 19:28:35]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kojii, 2016-12-02 06:50:35]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 06:50:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-12-02 06:53:09]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[kojii, 2016-12-02 06:53:17]

Patchset #3 (id:30001) has been deleted

[commit-bot: I haz the power, 2016-12-02 06:53:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-12-02 07:09:29]

Description was changed from

==========
Fix break-all/word-break when applied to inline elements

When mid-word break properties (word-break: break-all and word-wrap:
break-word) are applied to inline elements, and there are no characters
that can fit in the line, the line breaker should break at the last
break opportunity in the last run.

This patch fixes BreakingContext::rewindToMidWordBreak() to take such
case into account.

BUG=668399
==========

to

==========
Fix break-all/word-break are applied to inline elements

When mid-word break properties (word-break: break-all and word-wrap:
break-word) are applied to inline elements, and there are no characters
that can fit in the line, the line breaker should break at the last
break opportunity in the last run.

This patch fixes BreakingContext::rewindToMidWordBreak() to take such
case into account.Improve mixed break-all/break-word in a line

This patch improves when properties that can break lines in the middle
of a word (word-break: break-all and break-word) are applied to inline
elements.

When no characters can fit but there is a break opportunity in previous
runs, the line should break at the opportunity.

Also this fix revealed that we have tests of element boundaries relying
on parent's style, and they pass only under certain conditions. This
was fixed to refer to the parent's style, as recently clarfied in CSS
Text[1].

[1] https://github.com/w3c/csswg-drafts/issues/189

BUG=668399

BUG=668399
==========

[commit-bot: I haz the power, 2016-12-02 07:52:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 07:52:22]

Dry run: This issue passed the CQ dry run.

[kojii, 2016-12-02 07:57:07]

Description was changed from

==========
Fix break-all/word-break are applied to inline elements

When mid-word break properties (word-break: break-all and word-wrap:
break-word) are applied to inline elements, and there are no characters
that can fit in the line, the line breaker should break at the last
break opportunity in the last run.

This patch fixes BreakingContext::rewindToMidWordBreak() to take such
case into account.Improve mixed break-all/break-word in a line

This patch improves when properties that can break lines in the middle
of a word (word-break: break-all and break-word) are applied to inline
elements.

When no characters can fit but there is a break opportunity in previous
runs, the line should break at the opportunity.

Also this fix revealed that we have tests of element boundaries relying
on parent's style, and they pass only under certain conditions. This
was fixed to refer to the parent's style, as recently clarfied in CSS
Text[1].

[1] https://github.com/w3c/csswg-drafts/issues/189

BUG=668399

BUG=668399
==========

to

==========
Fix break-all/word-break are applied to inline elements

This patch improves when properties that can break lines in the middle
of a word (word-break: break-all and break-word) are applied to inline
elements.

When no characters can fit but there is a break opportunity in previous
runs, the line should break at the opportunity.

Also this fix revealed that we have tests of element boundaries relying
on parent's style, and they pass only under certain conditions. This
was fixed to refer to the parent's style, as recently clarified in CSS
Text[1].

[1] https://github.com/w3c/csswg-drafts/issues/189

BUG=668399
==========

[kojii, 2016-12-02 08:03:46]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2016-12-02 08:03:46]

PTAL. Sorry that I didn't understand well enough how to handle line breaks at
node boundaries when I fixed break-all last time. There's always new things to
learn!

[eae, 2016-12-02 09:53:05]

LGTM

[eae, 2016-12-02 09:53:13]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-12-02 09:53:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 10:04:04]

CQ is committing da patch.

Bot data: {"patchset_id": 50001, "attempt_start_ts": 1480672393130850,
"parent_rev": "3de8ee0333ba0fe7a072f64c6f6da14629d6c785", "commit_rev":
"09b57549da15ee3d4dbf1d195955f72e069f2a48"}

[commit-bot: I haz the power, 2016-12-02 10:04:29]

Committed patchset #3 (id:50001)

[commit-bot: I haz the power, 2016-12-02 10:06:08]

Description was changed from

==========
Fix break-all/word-break are applied to inline elements

This patch improves when properties that can break lines in the middle
of a word (word-break: break-all and break-word) are applied to inline
elements.

When no characters can fit but there is a break opportunity in previous
runs, the line should break at the opportunity.

Also this fix revealed that we have tests of element boundaries relying
on parent's style, and they pass only under certain conditions. This
was fixed to refer to the parent's style, as recently clarified in CSS
Text[1].

[1] https://github.com/w3c/csswg-drafts/issues/189

BUG=668399
==========

to

==========
Fix break-all/word-break are applied to inline elements

This patch improves when properties that can break lines in the middle
of a word (word-break: break-all and break-word) are applied to inline
elements.

When no characters can fit but there is a break opportunity in previous
runs, the line should break at the opportunity.

Also this fix revealed that we have tests of element boundaries relying
on parent's style, and they pass only under certain conditions. This
was fixed to refer to the parent's style, as recently clarified in CSS
Text[1].

[1] https://github.com/w3c/csswg-drafts/issues/189

BUG=668399

Committed: https://crrev.com/f2ba82966d78cccb307a6046606a616e27c1f0df
Cr-Commit-Position: refs/heads/master@{#435899}
==========

[commit-bot: I haz the power, 2016-12-02 10:06:09]

Patchset 3 (id:??) landed as
https://crrev.com/f2ba82966d78cccb307a6046606a616e27c1f0df
Cr-Commit-Position: refs/heads/master@{#435899}