Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2555453002: Share field trial allocator on MacOS (Closed)

Created:
4 years ago by lawrencewu
Modified:
4 years ago
CC:
chromium-reviews, mac-reviews_chromium.org, gavinp+memory_chromium.org, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Share field trial allocator on MacOS This CL shares the field trial allocator on MacOS. It depends on Mac having POSIX shared memory support, but other than that it is basically the same as the Linux CL: https://codereview.chromium.org/2530573002/. We just need to edit some ifdefs. BUG=663912

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M base/memory/shared_memory_handle_mac.cc View 1 chunk +0 lines, -1 line 1 comment Download
M base/metrics/field_trial.h View 1 chunk +1 line, -2 lines 0 comments Download
M base/metrics/field_trial.cc View 7 chunks +9 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (2 generated)
Alexei Svitkine (slow)
lgtm assuming you tested and still works after all your refactors on the other CL ...
4 years ago (2016-12-09 22:23:41 UTC) #3
lawrencewu
4 years ago (2016-12-09 22:31:14 UTC) #4
On 2016/12/09 22:23:41, Alexei Svitkine (slow) wrote:
> lgtm assuming you tested and still works after all your refactors on the other
> CL
> 
>
https://codereview.chromium.org/2555453002/diff/1/base/memory/shared_memory_h...
> File base/memory/shared_memory_handle_mac.cc (left):
> 
>
https://codereview.chromium.org/2555453002/diff/1/base/memory/shared_memory_h...
> base/memory/shared_memory_handle_mac.cc:180: 
> Nit: Remove extra diff here.

Closing: see https://codereview.chromium.org/2565683003/

Powered by Google App Engine
This is Rietveld 408576698