Resurrect POSIX shared memory support on mac

Resurrect POSIX shared memory support on mac

BUG=

[lawrencewu, 2016-12-02 19:14:08]

The CQ bit was checked by lawrencewu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 19:14:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lawrencewu, 2016-12-05 15:27:28]

The CQ bit was checked by lawrencewu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 15:27:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 15:34:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 15:34:36]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[erikchen, 2016-12-06 17:32:32]

erikchen@chromium.org changed reviewers:
+ erikchen@chromium.org

[erikchen, 2016-12-06 17:32:32]

https://codereview.chromium.org/2550723002/diff/80001/mojo/edk/embedder/platf...
File mojo/edk/embedder/platform_shared_buffer.cc (right):

https://codereview.chromium.org/2550723002/diff/80001/mojo/edk/embedder/platf...
mojo/edk/embedder/platform_shared_buffer.cc:36: if (memory_handle.GetType() ==
base::SharedMemoryHandle::MACH) {
we never pass posix SHM on Mac over Chrome/Mojo IPC, so the only changes to
mojo/ should be adding a bunch of NOTREACHED(), or perhaps even CHECK(false) to
make sure this doesn't happen in the wild.

[lawrencewu, 2016-12-06 18:17:04]

On 2016/12/06 17:32:32, erikchen wrote:
>
https://codereview.chromium.org/2550723002/diff/80001/mojo/edk/embedder/platf...
> File mojo/edk/embedder/platform_shared_buffer.cc (right):
> 
>
https://codereview.chromium.org/2550723002/diff/80001/mojo/edk/embedder/platf...
> mojo/edk/embedder/platform_shared_buffer.cc:36: if (memory_handle.GetType() ==
> base::SharedMemoryHandle::MACH) {
> we never pass posix SHM on Mac over Chrome/Mojo IPC, so the only changes to
> mojo/ should be adding a bunch of NOTREACHED(), or perhaps even CHECK(false)
to
> make sure this doesn't happen in the wild.

Closing, the new CL should be at https://codereview.chromium.org/2555483002/.

[lawrencewu, 2016-12-06 18:17:09]

Description was changed from

==========
Resurrect POSIX shared memory support on mac

BUG=
==========

to

==========
Resurrect POSIX shared memory support on mac

BUG=
==========