Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2555443002: Remove unused code for ApplyFixedAudioConstraints in media_stream_audio_processor. (Closed)

Created:
4 years ago by peah
Modified:
4 years ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, jasonroberts+watch_google.com, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused code for ApplyFixedAudioConstraints in media_stream_audio_processor. The reason for starting changing this code is that the code will be modified for the new way of setting parameters for the WebRTC audio processing module. BUG=chromium:671153 Committed: https://crrev.com/b06b2e05c52246c844e3a63d08bb0fc87b09bb1e Cr-Commit-Position: refs/heads/master@{#436353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M content/renderer/media/media_stream_audio_processor_options.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.cc View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
peah
4 years ago (2016-12-05 12:14:18 UTC) #5
hlundin-chromium
lgtm
4 years ago (2016-12-05 14:38:11 UTC) #6
peah
hbos@: PTAL. Thanks!
4 years ago (2016-12-05 14:49:45 UTC) #8
hbos_chromium
lgtm
4 years ago (2016-12-05 15:41:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555443002/1
4 years ago (2016-12-05 17:26:03 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 18:21:14 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-05 18:23:29 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b06b2e05c52246c844e3a63d08bb0fc87b09bb1e
Cr-Commit-Position: refs/heads/master@{#436353}

Powered by Google App Engine
This is Rietveld 408576698