Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Unified Diff: content/renderer/media/media_stream_audio_processor_options.cc

Issue 2555443002: Remove unused code for ApplyFixedAudioConstraints in media_stream_audio_processor. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/media_stream_audio_processor_options.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/media_stream_audio_processor_options.cc
diff --git a/content/renderer/media/media_stream_audio_processor_options.cc b/content/renderer/media/media_stream_audio_processor_options.cc
index 7c1c929d251612d8e6e3b5967887bb2b148b14ee..73e2b51aeb1a7761efd4d29c7d0e1e162aa4f309 100644
--- a/content/renderer/media/media_stream_audio_processor_options.cc
+++ b/content/renderer/media/media_stream_audio_processor_options.cc
@@ -134,32 +134,8 @@ bool ScanConstraintsForBoolean(
return the_default;
}
-void SetIfNotSet(rtc::Optional<bool>* field, bool value) {
- if (!*field) {
- *field = rtc::Optional<bool>(value);
- }
-}
-
} // namespace
-// TODO(xians): Remove this method after the APM in WebRtc is deprecated.
-void MediaAudioConstraints::ApplyFixedAudioConstraints(
- cricket::AudioOptions* options) {
- SetIfNotSet(&options->echo_cancellation, true);
-#if defined(OS_ANDROID)
- SetIfNotSet(&options->extended_filter_aec, false);
-#else
- // Enable the extended filter mode AEC on all non-mobile platforms.
- SetIfNotSet(&options->extended_filter_aec, true);
-#endif
- SetIfNotSet(&options->auto_gain_control, true);
- SetIfNotSet(&options->experimental_agc, true);
- SetIfNotSet(&options->noise_suppression, true);
- SetIfNotSet(&options->highpass_filter, true);
- SetIfNotSet(&options->typing_detection, true);
- SetIfNotSet(&options->experimental_ns, true);
-}
-
MediaAudioConstraints::MediaAudioConstraints(
const blink::WebMediaConstraints& constraints, int effects)
: constraints_(constraints),
« no previous file with comments | « content/renderer/media/media_stream_audio_processor_options.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698