Ensure that modal dialogs from subframes can be cleaned up correctly.

Ensure that modal dialogs from subframes can be cleaned up correctly.

BUG=366510
TEST=See bug comment 7 for repro steps.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266638

[Charlie Reis, 2014-04-25 00:52:40]

Avi, can you take a look?  It doesn't look like it will be a problem to clear
the children of the affected FrameTreeNodes after RenderViewTerminated.

[Avi (use Gerrit), 2014-04-25 02:54:48]

LGTM. Thanks for taking care of this.

[Charlie Reis, 2014-04-25 16:09:51]

Thanks.  +sky for OWNERS on browser_browsertest.cc.

[Charlie Reis, 2014-04-25 16:11:54]

Err, hold off for a bit while I figure out the try job failures.  This may not
be as simple as I thought.

[Charlie Reis, 2014-04-25 22:35:04]

Avi, can you take another look?  I've posted an explanation in comment 11 on the
bug.

[Avi (use Gerrit), 2014-04-25 23:57:02]

LGTM

[Charlie Reis, 2014-04-26 00:01:03]

Thanks!  @sky, can you review for chrome/ owners now?  I don't expect that code
will change, though I'm still waiting for try jobs.

[sky, 2014-04-28 13:40:46]

LGTM

[Charlie Reis, 2014-04-28 16:30:31]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2014-04-28 16:31:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/creis@chromium.org/255543009/40001

[commit-bot: I haz the power, 2014-04-28 19:58:40]

Change committed as 266638

[robliao, 2014-04-28 21:47:18]

A revert of this CL has been created in
https://codereview.chromium.org/257863004/ by robliao@chromium.org.

The reason for reverting is: Causes leaks:

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te...

Direct leak of 48 byte(s) in 1 object(s) allocated from:
    #0 0x56973b in operator new(unsigned long)
/usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
    #1 0x52464ce in IPC::SyncMessage::GenerateReply(IPC::Message const*)
ipc/ipc_sync_message.cc:99
    #2 0x9f6ec47 in Tuple4 ipc/ipc_message_utils.h:877
    #3 0x9f6ec47 in bool
FrameHostMsg_RunJavaScriptMessage::DispatchDelayReply\u003Ccontent::RenderFrameHostImpl,
void (content::RenderFrameHostImpl::*)(std::basic_string\u003Cunsigned short,
base::string16_char_traits, std::allocator\u003Cunsigned short> > const&,
std::basic_string\u003Cunsigned short, base::string16_char_traits,
std::allocator\u003Cunsigned short> > const&, GURL const&,
content::JavaScriptMessageType, IPC::Message*)>(IPC::Message const*,
content::RenderFrameHostImpl*, void
(content::RenderFrameHostImpl::*)(std::basic_string\u003Cunsigned short,
base::string16_char_traits, std::allocator\u003Cunsigned short> > const&,
std::basic_string\u003Cunsigned short, base::string16_char_traits,
std::allocator\u003Cunsigned short> > const&, GURL const&,
content::JavaScriptMessageType, IPC::Message*))
content/common/frame_messages.h:545
    #4 0x9f6b9d3 in content::RenderFrameHostImpl::OnMessageReceived(IPC::Message
const&) content/browser/frame_host/render_frame_host_impl.cc:287
    #5 0xa1185d9 in
content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const&)
content/browser/renderer_host/render_process_host_impl.cc:1346
    #6 0x5239eec in IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message
const&) ipc/ipc_channel_proxy.cc:269
    #7 0x3256fbf in Run base/callback.h:401
    #8 0x3256fbf in base::MessageLoop::RunTask(base::PendingTask const&)
base/message_loop/message_loop.cc:450
    #9 0x3258e35 in DeferOrRunPendingTask base/message_loop/message_loop.cc:462
    #10 0x3258e35 in base::MessageLoop::DoWork()
base/message_loop/message_loop.cc:576
    #11 0x32fab87 in base::MessagePumpGlib::Run(base::MessagePump::Delegate*)
base/message_loop/message_pump_glib.cc:270
    #12 0x3290314 in base::RunLoop::Run() base/run_loop.cc:49
    #13 0xc55c305 in content::RunThisRunLoop(base::RunLoop*)
content/public/test/test_utils.cc:103
    #14 0xc55e252 in operator-> content/public/test/test_utils.cc:165
    #15 0xc55e252 in content::WindowedNotificationObserver::Wait()
content/public/test/test_utils.cc:225
    #16 0x31af7c1 in ui_test_utils::WaitForAppModalDialog()
chrome/test/base/ui_test_utils.cc:342
    #17 0x19c1ed8 in
BrowserTest_SadTabCancelsSubframeDialogs_Test::RunTestOnMainThread()
chrome/browser/ui/browser_browsertest.cc:585
    #18 0x31996b8 in InProcessBrowserTest::RunTestOnMainThreadLoop()
chrome/test/base/in_process_browser_test.cc:419
.