Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: content/browser/web_contents/web_contents_impl.h

Issue 255543009: Ensure that modal dialogs from subframes can be cleaned up correctly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't store a possibly deleted RFH Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 647 matching lines...) Expand 10 before | Expand all | Expand 10 after
658 void OnWebContentsDestroyed(WebContentsImpl* web_contents); 658 void OnWebContentsDestroyed(WebContentsImpl* web_contents);
659 659
660 // Creates and adds to the map a destruction observer watching |web_contents|. 660 // Creates and adds to the map a destruction observer watching |web_contents|.
661 // No-op if such an observer already exists. 661 // No-op if such an observer already exists.
662 void AddDestructionObserver(WebContentsImpl* web_contents); 662 void AddDestructionObserver(WebContentsImpl* web_contents);
663 663
664 // Deletes and removes from the map a destruction observer 664 // Deletes and removes from the map a destruction observer
665 // watching |web_contents|. No-op if there is no such observer. 665 // watching |web_contents|. No-op if there is no such observer.
666 void RemoveDestructionObserver(WebContentsImpl* web_contents); 666 void RemoveDestructionObserver(WebContentsImpl* web_contents);
667 667
668 // Callback function when showing JavaScript dialogs. 668 // Callback function when showing JavaScript dialogs. Takes in a routing ID
669 void OnDialogClosed(RenderFrameHost* rfh, 669 // pair to identify the RenderFrameHost that opened the dialog, because it's
670 // possible for the RenderFrameHost to be deleted by the time this is called.
671 void OnDialogClosed(int render_process_id,
672 int render_frame_id,
670 IPC::Message* reply_msg, 673 IPC::Message* reply_msg,
671 bool dialog_was_suppressed, 674 bool dialog_was_suppressed,
672 bool success, 675 bool success,
673 const base::string16& user_input); 676 const base::string16& user_input);
674 677
675 // Callback function when requesting permission to access the PPAPI broker. 678 // Callback function when requesting permission to access the PPAPI broker.
676 // |result| is true if permission was granted. 679 // |result| is true if permission was granted.
677 void OnPpapiBrokerPermissionResult(int routing_id, bool result); 680 void OnPpapiBrokerPermissionResult(int routing_id, bool result);
678 681
679 bool OnMessageReceived(RenderViewHost* render_view_host, 682 bool OnMessageReceived(RenderViewHost* render_view_host,
(...skipping 412 matching lines...) Expand 10 before | Expand all | Expand 10 after
1092 1095
1093 // Whether the last JavaScript dialog shown was suppressed. Used for testing. 1096 // Whether the last JavaScript dialog shown was suppressed. Used for testing.
1094 bool last_dialog_suppressed_; 1097 bool last_dialog_suppressed_;
1095 1098
1096 DISALLOW_COPY_AND_ASSIGN(WebContentsImpl); 1099 DISALLOW_COPY_AND_ASSIGN(WebContentsImpl);
1097 }; 1100 };
1098 1101
1099 } // namespace content 1102 } // namespace content
1100 1103
1101 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 1104 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698