Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 255543002: Windows Installer: Remove unused resources or mark them as win-only. (Closed)

Created:
6 years, 8 months ago by Lei Zhang
Modified:
6 years, 8 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Windows Installer: Remove unused resources or mark them as win-only. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266156

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -103 lines) Patch
M chrome/app/chromium_strings.grd View 1 1 chunk +44 lines, -50 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +45 lines, -51 lines 0 comments Download
M chrome/installer/util/prebuild/create_string_rc.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
6 years, 8 months ago (2014-04-24 02:58:42 UTC) #1
grt (UTC plus 2)
lgtm. thanks for the cleanup!
6 years, 8 months ago (2014-04-24 19:52:03 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 8 months ago (2014-04-24 20:48:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/255543002/20001
6 years, 8 months ago (2014-04-24 21:15:47 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 08:28:59 UTC) #5
Message was sent while issue was closed.
Change committed as 266156

Powered by Google App Engine
This is Rietveld 408576698